[v3,0/4] hwmon: (ltc2945): add support for sense resistor

Message

Alexandru Ardelean Jan. 7, 2021, 10:34 a.m. UTC

Changeset adds support for sense resistor.

Changelog v2 -> v3:
* https://lore.kernel.org/linux-hwmon/[e-mail]/
* dropped patch 'docs: hwmon: (ltc2945): change type of val to ULL in ltc2945_val_to_reg()'
* add patch 'hwmon: (ltc2945): clamp values before converting'
* for patch 'hwmon: (ltc2945): add support for sense resistor'
  - sense-resistor is represented in milli-ohms internally; this
    risks of any other potential overflows with the multiplication to
    1000; the scaling in the driver becomes simpler, but we can't allow
    a lower resistor value that 1 mOhm, and all resistor values
    need to be integer in mOhm.
  - added max power and max amps limits, adjusted to sense resistor
* for patch 'dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945 '
  added 'Reviewed-by: Rob Herring <[e-mail]>'

Alexandru Ardelean (4):
  hwmon: (ltc2945): wrap regmap into an ltc2945_state struct
  hwmon: (ltc2945): clamp values before converting
  hwmon: (ltc2945): add support for sense resistor
  dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945

 .../bindings/hwmon/adi,ltc2945.yaml           |  49 +++++++
 drivers/hwmon/ltc2945.c                       | 128 +++++++++++++++---
 2 files changed, 156 insertions(+), 21 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml

Comments

Guenter Roeck Jan. 7, 2021, 3:28 p.m. UTC | #1

On Thu, Jan 07, 2021 at 12:34:13PM +0200, Alexandru Ardelean wrote:
> Changeset adds support for sense resistor.
> 
> Changelog v2 -> v3:
> * https://lore.kernel.org/linux-hwmon/[e-mail]/
> * dropped patch 'docs: hwmon: (ltc2945): change type of val to ULL in ltc2945_val_to_reg()'
> * add patch 'hwmon: (ltc2945): clamp values before converting'
> * for patch 'hwmon: (ltc2945): add support for sense resistor'
>   - sense-resistor is represented in milli-ohms internally; this
>     risks of any other potential overflows with the multiplication to
>     1000; the scaling in the driver becomes simpler, but we can't allow
>     a lower resistor value that 1 mOhm, and all resistor values
>     need to be integer in mOhm.
>   - added max power and max amps limits, adjusted to sense resistor
> * for patch 'dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945 '
>   added 'Reviewed-by: Rob Herring <[e-mail]>'
> 
> Alexandru Ardelean (4):
>   hwmon: (ltc2945): wrap regmap into an ltc2945_state struct
>   hwmon: (ltc2945): clamp values before converting
>   hwmon: (ltc2945): add support for sense resistor
>   dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945
> 

As mentioned in patch 3/3, this series solves a generic problem
affecting all hwmon drivers, but it only solves it for one of those
drivers. We should work on a generic solution (in-kernel scaling)
instead, one that works for all hwmon drivers, not just one.

Thanks,
Guenter

>  .../bindings/hwmon/adi,ltc2945.yaml           |  49 +++++++
>  drivers/hwmon/ltc2945.c                       | 128 +++++++++++++++---
>  2 files changed, 156 insertions(+), 21 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
> 
> -- 
> 2.17.1
>