mbox series

[0/4] hwmon: (sch56xx) Use devres for watchdog and platform_device_register_simple()

Message ID 20210507212404.6781-1-W_Armin@gmx.de (mailing list archive)
Headers show
Series hwmon: (sch56xx) Use devres for watchdog and platform_device_register_simple() | expand

Message

Armin Wolf May 7, 2021, 9:24 p.m. UTC 
From: Armin Wolf <W_Armin@gmx.de>

Since it was requested to use devres for the watchdog device,
use devm_watchdog_register() for watchdog registration and do
some small cleanups.

Also use platform_device_register_simple() in sch56xx_device_add().

Tested on a Fujitsu Esprimo P720.

Armin Wolf (4):
  hwmon: (sch56xx) Use devres functions for watchdog
  hwmon: (sch56xx-common) Use strscpy
  hwmon: (sch56xx-common) Use helper function
  hwmon: (sch56xx-common) Simplify sch56xx_device_add

 drivers/hwmon/sch5627.c        | 12 ++------
 drivers/hwmon/sch5636.c        |  9 ++----
 drivers/hwmon/sch56xx-common.c | 50 ++++++++--------------------------
 3 files changed, 16 insertions(+), 55 deletions(-)

--
2.20.1

Comments

Hans de Goede May 8, 2021, 8:59 a.m. UTC | #1 
Hi,

On 5/7/21 11:24 PM, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
> 
> Since it was requested to use devres for the watchdog device,
> use devm_watchdog_register() for watchdog registration and do
> some small cleanups.
> 
> Also use platform_device_register_simple() in sch56xx_device_add().
> 
> Tested on a Fujitsu Esprimo P720.
> 
> Armin Wolf (4):
>   hwmon: (sch56xx) Use devres functions for watchdog
>   hwmon: (sch56xx-common) Use strscpy
>   hwmon: (sch56xx-common) Use helper function
>   hwmon: (sch56xx-common) Simplify sch56xx_device_add

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

For the series.

Regards,

Hans