mbox series

[v2,0/6] Convert to new hwmon registration api

Message ID 20210528173716.10975-1-W_Armin@gmx.de (mailing list archive)
Headers show
Series Convert to new hwmon registration api | expand

Message

Armin Wolf May 28, 2021, 5:37 p.m. UTC
From: Armin Wolf <W_Armin@gmx.de>

This patch series is converting the dell-smm-hwmon driver
to the new hwmon registration API. In order to do so,
it introduces a platform device in the first patch, and
applies some optimisations in the next three patches.
The switch to the new hwmon registration API is done in
the last patch.

The caching of the fan/temp values was modified to better fit
the new hwmon API.

The patches work fine for my Dell Latitude C600, but i whould
appreciate someone testing the code on another model too.

Changes in v2:
- Fix coverletter title
- Update docs regarding pwm1_enable

Armin Wolf (6):
  hwmon: (dell-smm-hwmon) Use platform device
  hwmon: (dell-smm-hwmon) Mark functions as __init
  hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
  hwmon: (dell-smm-hwmon) Move variables into a driver private data
    structure
  hwmon: (dell-smm-hwmon) Convert to
    devm_hwmon_device_register_with_info()
  hwmon: (dell-smm-hwmon) Update docs

 Documentation/hwmon/dell-smm-hwmon.rst |   2 +-
 drivers/hwmon/dell-smm-hwmon.c         | 860 ++++++++++++-------------
 2 files changed, 426 insertions(+), 436 deletions(-)

--
2.20.1

Comments

Pali Rohár May 28, 2021, 6:32 p.m. UTC | #1
On Friday 28 May 2021 19:37:10 W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
> 
> This patch series is converting the dell-smm-hwmon driver
> to the new hwmon registration API. In order to do so,
> it introduces a platform device in the first patch, and
> applies some optimisations in the next three patches.
> The switch to the new hwmon registration API is done in
> the last patch.
> 
> The caching of the fan/temp values was modified to better fit
> the new hwmon API.
> 
> The patches work fine for my Dell Latitude C600, but i whould
> appreciate someone testing the code on another model too.
> 
> Changes in v2:
> - Fix coverletter title
> - Update docs regarding pwm1_enable
> 
> Armin Wolf (6):
>   hwmon: (dell-smm-hwmon) Use platform device
>   hwmon: (dell-smm-hwmon) Mark functions as __init
>   hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
>   hwmon: (dell-smm-hwmon) Move variables into a driver private data
>     structure
>   hwmon: (dell-smm-hwmon) Convert to
>     devm_hwmon_device_register_with_info()
>   hwmon: (dell-smm-hwmon) Update docs
> 
>  Documentation/hwmon/dell-smm-hwmon.rst |   2 +-
>  drivers/hwmon/dell-smm-hwmon.c         | 860 ++++++++++++-------------
>  2 files changed, 426 insertions(+), 436 deletions(-)
> 
> --
> 2.20.1
> 

Hello! I tried to apply this patch series but it failed on error
malformed patch. I guess that it is because patches in emails were sent
in quoted-printable transfer encoding (instead of transparent 8-bit).
I will look later how to convert them into 8-bit, for clean apply.
Pali Rohár May 28, 2021, 6:40 p.m. UTC | #2
On Friday 28 May 2021 20:32:54 Pali Rohár wrote:
> On Friday 28 May 2021 19:37:10 W_Armin@gmx.de wrote:
> > From: Armin Wolf <W_Armin@gmx.de>
> > 
> > This patch series is converting the dell-smm-hwmon driver
> > to the new hwmon registration API. In order to do so,
> > it introduces a platform device in the first patch, and
> > applies some optimisations in the next three patches.
> > The switch to the new hwmon registration API is done in
> > the last patch.
> > 
> > The caching of the fan/temp values was modified to better fit
> > the new hwmon API.
> > 
> > The patches work fine for my Dell Latitude C600, but i whould
> > appreciate someone testing the code on another model too.
> > 
> > Changes in v2:
> > - Fix coverletter title
> > - Update docs regarding pwm1_enable
> > 
> > Armin Wolf (6):
> >   hwmon: (dell-smm-hwmon) Use platform device
> >   hwmon: (dell-smm-hwmon) Mark functions as __init
> >   hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
> >   hwmon: (dell-smm-hwmon) Move variables into a driver private data
> >     structure
> >   hwmon: (dell-smm-hwmon) Convert to
> >     devm_hwmon_device_register_with_info()
> >   hwmon: (dell-smm-hwmon) Update docs
> > 
> >  Documentation/hwmon/dell-smm-hwmon.rst |   2 +-
> >  drivers/hwmon/dell-smm-hwmon.c         | 860 ++++++++++++-------------
> >  2 files changed, 426 insertions(+), 436 deletions(-)
> > 
> > --
> > 2.20.1
> > 
> 
> Hello! I tried to apply this patch series but it failed on error
> malformed patch. I guess that it is because patches in emails were sent
> in quoted-printable transfer encoding (instead of transparent 8-bit).
> I will look later how to convert them into 8-bit, for clean apply.

Quick "hack": in mutt just open email body in "v"-view and then save
content. It is then clean 8-bit, fully decoded and patch can be applied.