mbox series

[v3,0/2] hwmon: (it87) Add param to ignore ACPI resource

Message ID 20221004210100.540120-1-ahmad@khalifa.ws (mailing list archive)
Headers show
Series hwmon: (it87) Add param to ignore ACPI resource | expand

Message

Ahmad Khalifa Oct. 4, 2022, 9 p.m. UTC 
Changes in this patch set:

* Add parameter to ignore ACPI resource conflicts as an alternate to
  using 'acpi_enforce_resources=lax'.
  Some BIOSes reserve resources and don't use them and the system wide
  parameter may result in failures to certain drivers.

* Check there is a chip before using force_id parameter as there
  is no value in registering a non-existent chip


Code is inspired by the original it87 patchset dating back to 2017
(around 5 years and 2 weeks since the date of the original
ignore_resource_conflict param)

Tested with it8688 on Gigabyte board with id as it8628 and compared
against the out of tree module running the it8688 values (which in turn
is blindly based off of the it8686 values) and the results are the same
for the enabled sensors (i.e. not all 6 fans/temps/in are valid)


v2: updates with comments: [2]
* Add missing patch description, not just cover letter
* split change for the force_id check into separate commit

v3: v2 thread -> [3]
* Fix formatting and switch to 0 for permissions
* Patch descriptions and subject

[1]: https://lore.kernel.org/linux-hwmon/6c8b5fbd514df708af84630544eca6ee12766bbd.camel@crawford.emu.id.au/
[2]: https://lore.kernel.org/linux-hwmon/20221002151148.GA2896730@roeck-us.net/T/#u
[3]: https://lore.kernel.org/linux-hwmon/20221002174259.14609-1-ahmad@khalifa.ws/

Ahmad Khalifa (2):
  hwmon: (it87) Add param to ignore ACPI resource conflicts
  hwmon: (it87) Check for a valid chip before using force_id

 drivers/hwmon/it87.c | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)


base-commit: c3e0e1e23c70455916ff3472072437b3605c6cfe