[v2,0/3] drivers: thermal/hwmon: intel: Use model-specific bitmasks for temperature registers

Message

Ricardo Neri April 25, 2024, 5:13 p.m. UTC

Hi,

Here is v2 of the patchset to use model-specific bitmasks to read TCC
offset and the digital temperature readout of IA32_[PACKAGE]_THERM_STATUS.

You can read the cover letter of v1 here [1] for details.

Changes since v1:
 * Dropped dependency on CONFIG_INTEL_TCC for the coretemp driver.
   Instead, extend the bitmask to 0xff to accommodate recent processors.
   (Bit 23 of IA32_[PACKAGE]_THERM_STATUS is likely to be zero in less
   recent processors.)
 * Renamed TCC_FAM6_MODEL_TEMP_MASKS as TCC_MODEL_TEMP_MASKS.
 * Renamed get_tcc_offset_mask() as intel_tcc_get_offset_mask().
 * Do not export intel_tcc_get_temp_mask() as it is no longer used
   outside intel_tcc.c
 * Dropped stub functions for digital temperature readout and TCC
   offset. They are not needed as users select CONFIG_INTEL_TCC.

I have tested these patches on Alder Lake, Meteor Lake, and Grand Ridge
systems.

These patches apply cleanly on top of the `testing` branches of the
linux-pm and hwmon repositories.

Thanks and BR,
Ricardo

[1]. https://lore.kernel.org/linux-pm/[e-mail]/

Ricardo Neri (3):
  thermal: intel: intel_tcc: Add model checks for temperature registers
  thermal: intel: intel_tcc_cooling: Use a model-specific bitmask for
    TCC offset
  hwmon: (coretemp) Extend the bitmask to read temperature to 0xff

 drivers/hwmon/coretemp.c                  |   2 +-
 drivers/thermal/intel/intel_tcc.c         | 177 +++++++++++++++++++++-
 drivers/thermal/intel/intel_tcc_cooling.c |   2 +-
 include/linux/intel_tcc.h                 |   1 +
 4 files changed, 175 insertions(+), 7 deletions(-)