| Message ID | 20250124022635.16647-1-lihuisong@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use HWMON_CHANNEL_INFO macro to simplify code | expand |
On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote: > The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many > other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. > > Huisong Li (9): > media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code > net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code > net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code > net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code > net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code > rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code > rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code > w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code > net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code Please split these patches per subsystem. Maintainers generally have scripts to accept patches, and those scripts don't work when there are patches for other Maintainers mixed in. So you need 4 patchsets, media, net, rtc and w1. I would also like to see the HWMON Maintainers opinion on these. A patchset containing these have already been NACKed once. These patches do however look like valid cleanups. But are they just so you can do something bad in your vendor tree, which will never make it to mainline? Andrew
On 1/24/25 07:08, Andrew Lunn wrote: > On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote: >> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many >> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. >> >> Huisong Li (9): >> media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code >> net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code >> net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code >> rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code >> rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code >> w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code > > Please split these patches per subsystem. Maintainers generally have > scripts to accept patches, and those scripts don't work when there are > patches for other Maintainers mixed in. So you need 4 patchsets, > media, net, rtc and w1. > > I would also like to see the HWMON Maintainers opinion on these. A > patchset containing these have already been NACKed once. These patches > do however look like valid cleanups. But are they just so you can do > something bad in your vendor tree, which will never make it to > mainline? > I no longer comment on hwmon related changes outside drivers/hwmon/ unless there are blatant problems such as someone trying to use an obsolete API or abusing the current API. Guenter
On 24/01/2025 03:26, Huisong Li wrote: > The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many > other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. > Read the feedback given to you last time. I do not see how you addressed this: "Avoid combining independent patches into one patch bomb. Or explain the dependencies and how is it supposed to be merged - that's why you have cover letter here." Best regards, Krzysztof
在 2025/1/25 0:58, Krzysztof Kozlowski 写道: > On 24/01/2025 03:26, Huisong Li wrote: >> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many >> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. >> > Read the feedback given to you last time. I do not see how you addressed > this: > > "Avoid combining independent patches into one patch bomb. Or explain the > dependencies and how is it supposed to be merged - that's why you have > cover letter here." Sorry. I got it now. Thank you for telling me again.
Hi Andrew, 在 2025/1/24 23:08, Andrew Lunn 写道: > On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote: >> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely by many >> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify code. >> >> Huisong Li (9): >> media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code >> net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code >> net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code >> rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code >> rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code >> w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code >> net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code > Please split these patches per subsystem. Maintainers generally have > scripts to accept patches, and those scripts don't work when there are > patches for other Maintainers mixed in. So you need 4 patchsets, > media, net, rtc and w1. Many thanks for your reply and good suggestion. I will split them. > > I would also like to see the HWMON Maintainers opinion on these. A > patchset containing these have already been NACKed once. These patches > do however look like valid cleanups. But are they just so you can do > something bad in your vendor tree, which will never make it to > mainline? > > Andrew > > .
在 2025/1/24 23:41, Guenter Roeck 写道: > On 1/24/25 07:08, Andrew Lunn wrote: >> On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote: >>> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely >>> by many >>> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify >>> code. >>> >>> Huisong Li (9): >>> media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code >>> net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code >>> net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code >>> net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code >>> net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code >>> rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code >>> rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code >>> w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code >>> net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code >> >> Please split these patches per subsystem. Maintainers generally have >> scripts to accept patches, and those scripts don't work when there are >> patches for other Maintainers mixed in. So you need 4 patchsets, >> media, net, rtc and w1. >> >> I would also like to see the HWMON Maintainers opinion on these. A >> patchset containing these have already been NACKed once. These patches >> do however look like valid cleanups. But are they just so you can do >> something bad in your vendor tree, which will never make it to >> mainline? >> > > I no longer comment on hwmon related changes outside drivers/hwmon/ > unless there are blatant problems such as someone trying to use an > obsolete > API or abusing the current API. > > All right. Let subsystem maintainer to decide if need to pick it up. > > .