diff mbox

hwmon: (it87) Fix feature mask for IT8792E (IT8733E)

Message ID 1489245446-6352-1-git-send-email-linux@roeck-us.net
State Accepted
Headers show

Commit Message

Guenter Roeck March 11, 2017, 3:17 p.m. UTC
The chip features match those of IT8790E. Most important is the
ADC resolution, which is 12 mV, not 10.9 mV. It also uses the 'new'
set of registers for PECI control, and has a second PWM frequency
register.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/it87.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Guenter Roeck March 20, 2017, 10:45 p.m. UTC | #1
On Sat, Mar 11, 2017 at 07:17:26AM -0800, Guenter Roeck wrote:
> The chip features match those of IT8790E. Most important is the
> ADC resolution, which is 12 mV, not 10.9 mV. It also uses the 'new'
> set of registers for PECI control, and has a second PWM frequency
> register.
> 
Actually, turns out the ADC resolution is wrong. Both chips have an ADC
resolution of 10.9mV. Only the datasheet for IT8792E contradicts itself
and claims in one place that the resolution is 12mV and elsewhere that
it is 10.9mV. A test with a real chip suggests that 10.9mV is correct.

Guenter

> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/hwmon/it87.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index efb01c247e2d..3e57a6120551 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -428,11 +428,10 @@ static const struct it87_devices it87_devices[] = {
>  	[it8792] = {
>  		.name = "it8792",
>  		.suffix = "E",
> -		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
> -		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
> -		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
> +		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
> +		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
> +		  | FEAT_PWM_FREQ2,
>  		.peci_mask = 0x07,
> -		.old_peci_mask = 0x02,	/* Actually reports PCH */
>  	},
>  	[it8603] = {
>  		.name = "it8603",
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
index efb01c247e2d..3e57a6120551 100644
--- a/drivers/hwmon/it87.c
+++ b/drivers/hwmon/it87.c
@@ -428,11 +428,10 @@  static const struct it87_devices it87_devices[] = {
 	[it8792] = {
 		.name = "it8792",
 		.suffix = "E",
-		.features = FEAT_NEWER_AUTOPWM | FEAT_16BIT_FANS
-		  | FEAT_TEMP_OFFSET | FEAT_TEMP_OLD_PECI | FEAT_TEMP_PECI
-		  | FEAT_10_9MV_ADC | FEAT_IN7_INTERNAL,
+		.features = FEAT_NEWER_AUTOPWM | FEAT_12MV_ADC | FEAT_16BIT_FANS
+		  | FEAT_TEMP_OFFSET | FEAT_TEMP_PECI | FEAT_IN7_INTERNAL
+		  | FEAT_PWM_FREQ2,
 		.peci_mask = 0x07,
-		.old_peci_mask = 0x02,	/* Actually reports PCH */
 	},
 	[it8603] = {
 		.name = "it8603",