From patchwork Sun Mar 11 02:59:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 10274491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D79DB60211 for ; Sun, 11 Mar 2018 02:59:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C883028C6E for ; Sun, 11 Mar 2018 02:59:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB02F28C99; Sun, 11 Mar 2018 02:59:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6250C28DE9 for ; Sun, 11 Mar 2018 02:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbeCKC7L (ORCPT ); Sat, 10 Mar 2018 21:59:11 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:38209 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbeCKC7K (ORCPT ); Sat, 10 Mar 2018 21:59:10 -0500 Received: by mail-oi0-f65.google.com with SMTP id h23so9815156oib.5 for ; Sat, 10 Mar 2018 18:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=QpXdhTxO9bnj1BVYR76xJ5U1eVNEiWq+8f0GeOGHq9k=; b=Vpcm6wHvBN5P0vMP4VoyzRGs2fvF2eprre0R7EwlhBnHyAH3vRpNADUatrbiDgx0lI gIsK6jVKYVi45rU3GGHg9bAF42d6dUxBHxJ+F1d0ac6q/oa2JHRsJeWiRb5yzNRLBwpg 59cSc3ERdxAD78iyrGECQ8WV/mjdcy3P9H/KTMmj3HI/6zYx7qictSWORt8J39eP2Q/4 hhBIs1JcGZAamYzuhK2D2pL5OU25yhRnBmaUz2Jx2raTsFqbWZzUpqP4iT+ePavq/M7c EXlLFxc44UM4C4yT+LP4DJw4J4G0RkDhc2TYjp2EjIUA0n/mhTjZEGfSsQse7AskX88S qmDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=QpXdhTxO9bnj1BVYR76xJ5U1eVNEiWq+8f0GeOGHq9k=; b=AkxMvZRXIL1G6tQEMLKgByTizeKY3rV7JrHiyC9eop9tz8D1Pq6Jj6ztfWHlN1V8KY 5oZ7k9cUZ5tRzJcbkMptdsn64U0tictfvDkK6Uf1jKW8QEtmeETKyFUyjiX0Ylz9+P/Z sLNhYCKpIjpH0q1oLqdlwMDxT9jbD9exktnMTOCv0hHpqi22wpRIM53Jc0niSFB1P/8E PnjAn8dmS2KNf+b7e2ZQpzxDEjWehJeS+5krxRCcGd5lvNBwDvw5nmOCybg+W2yMtW0h ddKAtjeOMRAp73/e5XzVUXafMKPnd7A3+C9SJzypvsRpGflztEw82FkWhlxHHYYuXTlV jJNw== X-Gm-Message-State: AElRT7FAUDB3TKjsXt7OwB2EteSutOtcyQYPkkJnpzo5Lr+NCrFSzbip AOWwjfRyFVidF2QzRAXlT80wmQ== X-Google-Smtp-Source: AG47ELs0JnaJ9uc9UQJSoEWysn1nEQNy+JLDcpTSpIpW7ytpIJktfekvSyYdU/6ZlBrMBGsX9rozog== X-Received: by 10.202.40.1 with SMTP id 1mr2058375oix.53.1520737149983; Sat, 10 Mar 2018 18:59:09 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id f72sm2250695oih.52.2018.03.10.18.59.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Mar 2018 18:59:09 -0800 (PST) From: Guenter Roeck To: Hardware Monitoring Cc: Jean Delvare , Guenter Roeck Subject: [PATCH 2/3] hwmon: (pmbus/adm1275) Accept negative page register values Date: Sat, 10 Mar 2018 18:59:03 -0800 Message-Id: <1520737144-7955-2-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520737144-7955-1-git-send-email-linux@roeck-us.net> References: <1520737144-7955-1-git-send-email-linux@roeck-us.net> Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A negative page register value means that no page needs to be selected. This is used by status register read operations and needs to be accepted. The failure to do so so results in missed status and limit registers. Fixes: da8e48ab483e1 ("hwmon: (pmbus) Always call _pmbus_read_byte in core driver") Signed-off-by: Guenter Roeck --- drivers/hwmon/pmbus/adm1275.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c index 00d6995af4c2..8a44e94d5679 100644 --- a/drivers/hwmon/pmbus/adm1275.c +++ b/drivers/hwmon/pmbus/adm1275.c @@ -154,7 +154,7 @@ static int adm1275_read_word_data(struct i2c_client *client, int page, int reg) const struct adm1275_data *data = to_adm1275_data(info); int ret = 0; - if (page) + if (page > 0) return -ENXIO; switch (reg) { @@ -240,7 +240,7 @@ static int adm1275_write_word_data(struct i2c_client *client, int page, int reg, const struct adm1275_data *data = to_adm1275_data(info); int ret; - if (page) + if (page > 0) return -ENXIO; switch (reg) {