From patchwork Sun Sep 16 14:47:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 10601707 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 43DF615A6 for ; Sun, 16 Sep 2018 14:47:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2FEA0294C5 for ; Sun, 16 Sep 2018 14:47:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23295294F7; Sun, 16 Sep 2018 14:47:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,URIBL_SBL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95D72294C5 for ; Sun, 16 Sep 2018 14:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727808AbeIPUKh (ORCPT ); Sun, 16 Sep 2018 16:10:37 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41766 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbeIPUKh (ORCPT ); Sun, 16 Sep 2018 16:10:37 -0400 Received: by mail-pg1-f194.google.com with SMTP id s15-v6so6464208pgv.8 for ; Sun, 16 Sep 2018 07:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=LukJVHvZ+MfWBPPttHGE/122N+MvlQtTIPfjnY/ao/I=; b=XD073WwHaVH/go5UBX4uFaHhpiA9pN4PH0Znn/g6oIKqjcvo2PUdTVEk+Iy/6R8h4v ab+5erehhreiKbYSTZCGt5Wj7RZnA1HYm1iXXozGHPfihPqUMJlArgkscnSuLuFOE9Zs Q5j3zSvZZWdTSVoQ8qI8sl/dPlKpHIXgFyGnrfNNs0zrVCJJGe0+DKXWojAxNACHeTXf PJq59y8oK58C4ZjzalDYB3+eZgOmroRnjsOl15Eb0gL5XBj1QV2PcRC0UL9q847qzhwk p0GmFELjsdrUI20cYfLWAjlfZn4mDAXIvIOcrvrO7VUoELmv29obtFkCtMQ09DX87oFN KYxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=LukJVHvZ+MfWBPPttHGE/122N+MvlQtTIPfjnY/ao/I=; b=A9JfMN5/kzq3PrPqnyzeknN7Pj9UgVd6LgXYRKRXeHpJAgMMnMzud9Ik1X7HrXjy5V GyYZYyMsMAvsTomoeQBfC8WvNesR4nkIlYREczwkeWm2iXsTAfamyc3ogxMFDQtYrPpj 4uWFLCxZZY15hwoS8IhW+0kfL/a9t6waChYRpbha9oOWxZpMYUAkdGG7c4IbCyrAQiVb MYKGh4QcoALOgzpA007cYMBEVUehA9H2aCHdENZeMc/U4DdulfNxxPFgA/5H6TQPHic9 rX3lypsiwGFEttkwIAnPw1YIH9TJ7qCbuVpfVSX5oyYYnmrAhUSK4CF2MEr+w5Ai3otl LmfQ== X-Gm-Message-State: APzg51AKKIR3KZ+yR/UjCXlArhVP+Dc7AOtNW1kIuxB8O3Sh6wWv68kl cIykCTTODNzqXQ5/fLlmXqPyxMLP X-Google-Smtp-Source: ANB0VdaPVbe9ByptmU2PlTQz3x9UDeSo6IQrOkQc+LrAPp3aTyDRM5B/qSd7y2VkpWlKJBez21VmBg== X-Received: by 2002:a62:2744:: with SMTP id n65-v6mr22114748pfn.125.1537109245313; Sun, 16 Sep 2018 07:47:25 -0700 (PDT) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id u11-v6sm16148049pgj.71.2018.09.16.07.47.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Sep 2018 07:47:24 -0700 (PDT) From: Guenter Roeck To: Hardware Monitoring Cc: Jean Delvare , Guenter Roeck Subject: [PATCH] hwmon: (lm92) Fix whitespace issues Date: Sun, 16 Sep 2018 07:47:22 -0700 Message-Id: <1537109242-21449-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sparse complains: drivers/hwmon/lm92.c:209 set_temp_hyst() warn: inconsistent indenting While at it, fix various other whitespace issues reported by checkpatch (double empty lines, missing empty lines, whitespace at empty line). Signed-off-by: Guenter Roeck Reviewed-by: Jean Delvare --- drivers/hwmon/lm92.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c index d40fe5122e94..e7333f8e185c 100644 --- a/drivers/hwmon/lm92.c +++ b/drivers/hwmon/lm92.c @@ -127,8 +127,8 @@ static struct lm92_data *lm92_update_device(struct device *dev) mutex_lock(&data->update_lock); - if (time_after(jiffies, data->last_updated + HZ) - || !data->valid) { + if (time_after(jiffies, data->last_updated + HZ) || + !data->valid) { dev_dbg(&client->dev, "Updating lm92 data\n"); for (i = 0; i < t_num_regs; i++) { data->temp[i] = @@ -153,7 +153,7 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *devattr, } static ssize_t set_temp(struct device *dev, struct device_attribute *devattr, - const char *buf, size_t count) + const char *buf, size_t count) { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct lm92_data *data = dev_get_drvdata(dev); @@ -161,7 +161,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *devattr, int nr = attr->index; long val; int err; - + err = kstrtol(buf, 10, &val); if (err) return err; @@ -178,6 +178,7 @@ static ssize_t show_temp_hyst(struct device *dev, { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); struct lm92_data *data = lm92_update_device(dev); + return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[attr->index]) - TEMP_FROM_REG(data->temp[t_hyst])); } @@ -186,6 +187,7 @@ static ssize_t temp1_min_hyst_show(struct device *dev, struct device_attribute *attr, char *buf) { struct lm92_data *data = lm92_update_device(dev); + return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[t_min]) + TEMP_FROM_REG(data->temp[t_hyst])); } @@ -206,7 +208,7 @@ static ssize_t set_temp_hyst(struct device *dev, val = clamp_val(val, -120000, 220000); mutex_lock(&data->update_lock); - data->temp[t_hyst] = + data->temp[t_hyst] = TEMP_TO_REG(TEMP_FROM_REG(data->temp[attr->index]) - val); i2c_smbus_write_word_swapped(client, LM92_REG_TEMP_HYST, data->temp[t_hyst]); @@ -218,6 +220,7 @@ static ssize_t alarms_show(struct device *dev, struct device_attribute *attr, char *buf) { struct lm92_data *data = lm92_update_device(dev); + return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->temp[t_input])); } @@ -324,7 +327,6 @@ static int lm92_probe(struct i2c_client *new_client, return PTR_ERR_OR_ZERO(hwmon_dev); } - /* * Module and driver stuff */