| Message ID | 1541937671-26385-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: rpi: Fix initial notify | expand |
On Sun, Nov 11, 2018 at 01:01:11PM +0100, Stefan Wahren wrote: > In case an under-voltage happens before probing the driver wont > write the critical warning into the kernel log. So don't init > of last_throttled during probe and fix this issue. > > Fixes: 74d1e007915f ("hwmon: Add support for RPi voltage sensor") > Reported-by: "Noralf Trønnes" <noralf@tronnes.org> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Applied. Thanks, Guenter > --- > drivers/hwmon/raspberrypi-hwmon.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/hwmon/raspberrypi-hwmon.c b/drivers/hwmon/raspberrypi-hwmon.c > index be5ba46..0d04572 100644 > --- a/drivers/hwmon/raspberrypi-hwmon.c > +++ b/drivers/hwmon/raspberrypi-hwmon.c > @@ -115,7 +115,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct rpi_hwmon_data *data; > - int ret; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > if (!data) > @@ -124,11 +123,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) > /* Parent driver assure that firmware is correct */ > data->fw = dev_get_drvdata(dev->parent); > > - /* Init throttled */ > - ret = rpi_firmware_property(data->fw, RPI_FIRMWARE_GET_THROTTLED, > - &data->last_throttled, > - sizeof(data->last_throttled)); > - > data->hwmon_dev = devm_hwmon_device_register_with_info(dev, "rpi_volt", > data, > &rpi_chip_info, > -- > 2.7.4 >
diff --git a/drivers/hwmon/raspberrypi-hwmon.c b/drivers/hwmon/raspberrypi-hwmon.c index be5ba46..0d04572 100644 --- a/drivers/hwmon/raspberrypi-hwmon.c +++ b/drivers/hwmon/raspberrypi-hwmon.c @@ -115,7 +115,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct rpi_hwmon_data *data; - int ret; data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); if (!data) @@ -124,11 +123,6 @@ static int rpi_hwmon_probe(struct platform_device *pdev) /* Parent driver assure that firmware is correct */ data->fw = dev_get_drvdata(dev->parent); - /* Init throttled */ - ret = rpi_firmware_property(data->fw, RPI_FIRMWARE_GET_THROTTLED, - &data->last_throttled, - sizeof(data->last_throttled)); - data->hwmon_dev = devm_hwmon_device_register_with_info(dev, "rpi_volt", data, &rpi_chip_info,
In case an under-voltage happens before probing the driver wont write the critical warning into the kernel log. So don't init of last_throttled during probe and fix this issue. Fixes: 74d1e007915f ("hwmon: Add support for RPi voltage sensor") Reported-by: "Noralf Trønnes" <noralf@tronnes.org> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- drivers/hwmon/raspberrypi-hwmon.c | 6 ------ 1 file changed, 6 deletions(-)