From patchwork Mon Dec 10 22:08:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 10722631 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E7F4159A for ; Mon, 10 Dec 2018 22:09:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6EDE72A499 for ; Mon, 10 Dec 2018 22:09:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6374B2A73B; Mon, 10 Dec 2018 22:09:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 087A82A499 for ; Mon, 10 Dec 2018 22:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729533AbeLJWJI (ORCPT ); Mon, 10 Dec 2018 17:09:08 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:37445 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729444AbeLJWJI (ORCPT ); Mon, 10 Dec 2018 17:09:08 -0500 Received: by mail-pg1-f194.google.com with SMTP id 80so5623274pge.4 for ; Mon, 10 Dec 2018 14:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=VHODwZHoGgh2AN+bLy86+YAkhA35MjE0hpXBe1R2sA8=; b=IAeT1/YPfIYwSkxdaae6GxsjSSOpYq4Pm+DKMAni4p7ct8ShckfVEATbYTS+r0hS+h s7CDnXiS5V1RbXXyJOY2xtshXLx+jkFYmAO6kA383kjUKUyC3ZV86fEjBnt+vo6ta1F0 98tS5mAa3ihSAiTdgRElA7C9QIufx6+I3UuibLq4Ro6zcNdkhK5AWzrdbw2FwgxWFffm b41eFSwwzQVsnlHf+2tzt898wy1duhifQVbXnTsnbOzFbpGKoqOMjshkmH0bAbAWbZLa 4s6wIRov523utuY90zNsmwZFq78y/4Xa9mJ0Ta0e+IWBKie4/lPQJMTJku6592quWaif 9ZlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=VHODwZHoGgh2AN+bLy86+YAkhA35MjE0hpXBe1R2sA8=; b=RCr49aRV31bAK8ku3Ez+JqWWQYZeMV8ZRuefbKxdDKt0u1jLzmA6aXK9C1gbYWfodZ IG0U35DWJG7tSFLVxqlOnN5qX1gpr7E+UXE59K5pFrd3p8LK9eAz3tRKhitXnpmorvlt MxWUeLtGj3TYk4Y1Lm1zTevD8qZqekMDLklr97zff2TOi7Wqr0xg+WOXGP5cM4Iis4Ok R+EuwvIvNuGL6bLYWnF1eEaqOImtajuTOICVvooif3fQ5jsvXMCJJzwXILKMX4Vfzuct JktLhhkM1EWoZ6jqwjLVbTCrJi3X3KliYBv6WMMgf7vhir3As6EVjMuAaeaqEEHDk3RL 2lhw== X-Gm-Message-State: AA+aEWapB1eqto91GC961mfv3kwu4Z43qkbbIruqH17MbQ0PTZfmgMja kIuILLMqSY5r+GEkRCfM2liYfQDD X-Google-Smtp-Source: AFSGD/XtuVcRnym3uvACa9kJhBJGjVZw3D/58dSSMGqaGC43Er9zGJcDuU0hWClo/mKTlmAA5GOd6Q== X-Received: by 2002:a62:3a04:: with SMTP id h4mr13849874pfa.119.1544479747411; Mon, 10 Dec 2018 14:09:07 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n73sm17512894pfj.148.2018.12.10.14.09.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Dec 2018 14:09:06 -0800 (PST) From: Guenter Roeck To: Hardware Monitoring Cc: Jean Delvare , Guenter Roeck Subject: [PATCH 11/30] hwmon: (ads7871) Use permission specific SENSOR[_DEVICE]_ATTR variants Date: Mon, 10 Dec 2018 14:08:29 -0800 Message-Id: <1544479728-30077-12-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1544479728-30077-1-git-send-email-linux@roeck-us.net> References: <1544479728-30077-1-git-send-email-linux@roeck-us.net> Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, to improve readbility, and to reduce the chance of inconsistencies. Also replace any remaining S_ in the driver with octal values. The conversion was done automatically with coccinelle. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck --- drivers/hwmon/ads7871.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 59bd7b9e1772..cd14c1501508 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -96,8 +96,8 @@ static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) return spi_write(spi, tmp, sizeof(tmp)); } -static ssize_t show_voltage(struct device *dev, - struct device_attribute *da, char *buf) +static ssize_t voltage_show(struct device *dev, struct device_attribute *da, + char *buf) { struct ads7871_data *pdata = dev_get_drvdata(dev); struct spi_device *spi = pdata->spi; @@ -138,14 +138,14 @@ static ssize_t show_voltage(struct device *dev, } } -static SENSOR_DEVICE_ATTR(in0_input, S_IRUGO, show_voltage, NULL, 0); -static SENSOR_DEVICE_ATTR(in1_input, S_IRUGO, show_voltage, NULL, 1); -static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, show_voltage, NULL, 2); -static SENSOR_DEVICE_ATTR(in3_input, S_IRUGO, show_voltage, NULL, 3); -static SENSOR_DEVICE_ATTR(in4_input, S_IRUGO, show_voltage, NULL, 4); -static SENSOR_DEVICE_ATTR(in5_input, S_IRUGO, show_voltage, NULL, 5); -static SENSOR_DEVICE_ATTR(in6_input, S_IRUGO, show_voltage, NULL, 6); -static SENSOR_DEVICE_ATTR(in7_input, S_IRUGO, show_voltage, NULL, 7); +static SENSOR_DEVICE_ATTR_RO(in0_input, voltage, 0); +static SENSOR_DEVICE_ATTR_RO(in1_input, voltage, 1); +static SENSOR_DEVICE_ATTR_RO(in2_input, voltage, 2); +static SENSOR_DEVICE_ATTR_RO(in3_input, voltage, 3); +static SENSOR_DEVICE_ATTR_RO(in4_input, voltage, 4); +static SENSOR_DEVICE_ATTR_RO(in5_input, voltage, 5); +static SENSOR_DEVICE_ATTR_RO(in6_input, voltage, 6); +static SENSOR_DEVICE_ATTR_RO(in7_input, voltage, 7); static struct attribute *ads7871_attrs[] = { &sensor_dev_attr_in0_input.dev_attr.attr,