| Message ID | 1544603796-173016-1-git-send-email-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] hwmon: Fix debugfs_simple_attr.cocci warnings | expand |
On Wed, Dec 12, 2018 at 08:36:36AM +0000, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied. In future patches, please refer to the affected driver in the subject line. Thanks, Guenter > --- > drivers/hwmon/asus_atk0110.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c > index a5638d1..22be78c 100644 > --- a/drivers/hwmon/asus_atk0110.c > +++ b/drivers/hwmon/asus_atk0110.c > @@ -681,10 +681,8 @@ static int atk_debugfs_gitm_get(void *p, u64 *val) > return err; > } > > -DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm, > - atk_debugfs_gitm_get, > - NULL, > - "0x%08llx\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(atk_debugfs_gitm, atk_debugfs_gitm_get, NULL, > + "0x%08llx\n"); > > static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj) > { > @@ -803,8 +801,8 @@ static void atk_debugfs_init(struct atk_data *data) > if (!f || IS_ERR(f)) > goto cleanup; > > - f = debugfs_create_file("gitm", 0400, d, data, > - &atk_debugfs_gitm); > + f = debugfs_create_file_unsafe("gitm", 0400, d, data, > + &atk_debugfs_gitm); > if (!f || IS_ERR(f)) > goto cleanup; >
diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c index a5638d1..22be78c 100644 --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -681,10 +681,8 @@ static int atk_debugfs_gitm_get(void *p, u64 *val) return err; } -DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm, - atk_debugfs_gitm_get, - NULL, - "0x%08llx\n"); +DEFINE_DEBUGFS_ATTRIBUTE(atk_debugfs_gitm, atk_debugfs_gitm_get, NULL, + "0x%08llx\n"); static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj) { @@ -803,8 +801,8 @@ static void atk_debugfs_init(struct atk_data *data) if (!f || IS_ERR(f)) goto cleanup; - f = debugfs_create_file("gitm", 0400, d, data, - &atk_debugfs_gitm); + f = debugfs_create_file_unsafe("gitm", 0400, d, data, + &atk_debugfs_gitm); if (!f || IS_ERR(f)) goto cleanup;
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/hwmon/asus_atk0110.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)