| Message ID | 1621589904-64475-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | platform/x86: thinkpad_acpi: Fix inconsistent indenting | expand |
Hi, On 5/21/21 11:38 AM, Jiapeng Chong wrote: > Eliminate the follow smatch warning: > > drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn: > inconsistent indenting. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index dd60c93..d0aa566 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -7939,7 +7939,7 @@ static int volume_write(char *buf) > } else if (sscanf(cmd, "level %u", &l) == 1 && > l >= 0 && l <= TP_EC_VOLUME_MAX) { > new_level = l; > - continue; > + continue; > } > } > if (strlencmp(cmd, "mute") == 0) Thank you for your patch, but actually the indentation of the "new_level = l;" is wrong, it is indented one level too much. Please send a new version changing (reducing) the indentation of the "new_level = l;" statement instead. Regards, Hans
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index dd60c93..d0aa566 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -7939,7 +7939,7 @@ static int volume_write(char *buf) } else if (sscanf(cmd, "level %u", &l) == 1 && l >= 0 && l <= TP_EC_VOLUME_MAX) { new_level = l; - continue; + continue; } } if (strlencmp(cmd, "mute") == 0)
Eliminate the follow smatch warning: drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn: inconsistent indenting. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)