diff mbox series

[8/8] hwmon: nzxt-kraken2: Simplify specifying static visibility attribute

Message ID 1ac2be2d-df4f-455a-900d-821fc7bd12c4@gmail.com (mailing list archive)
State Accepted
Headers show
Series hwmon: Use new member visible in struct hwmon_ops to simplify drivers | expand

Commit Message

Heiner Kallweit Oct. 11, 2024, 8:04 p.m. UTC 
Use new member visible of struct hwmon_ops to simplify specifying
the static attribute visibility.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/hwmon/nzxt-kraken2.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Jonas Malaco Oct. 12, 2024, 12:02 a.m. UTC | #1 
On Fri, Oct 11, 2024 at 10:04:31PM +0200, Heiner Kallweit wrote:
> Use new member visible of struct hwmon_ops to simplify specifying
> the static attribute visibility.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Jonas Malaco <jonas@protocubo.io>
diff mbox series

Patch

diff --git a/drivers/hwmon/nzxt-kraken2.c b/drivers/hwmon/nzxt-kraken2.c
index ed38645a1..034698232 100644
--- a/drivers/hwmon/nzxt-kraken2.c
+++ b/drivers/hwmon/nzxt-kraken2.c
@@ -35,13 +35,6 @@  struct kraken2_priv_data {
 	unsigned long updated; /* jiffies */
 };
 
-static umode_t kraken2_is_visible(const void *data,
-				  enum hwmon_sensor_types type,
-				  u32 attr, int channel)
-{
-	return 0444;
-}
-
 static int kraken2_read(struct device *dev, enum hwmon_sensor_types type,
 			u32 attr, int channel, long *val)
 {
@@ -81,7 +74,7 @@  static int kraken2_read_string(struct device *dev, enum hwmon_sensor_types type,
 }
 
 static const struct hwmon_ops kraken2_hwmon_ops = {
-	.is_visible = kraken2_is_visible,
+	.visible = 0444,
 	.read = kraken2_read,
 	.read_string = kraken2_read_string,
 };