| Message ID | 20160829120634.039204a6@endymion (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: > I'm trying to find when the bug was introduced. I have a hard time > believing it went unnoticed for long. If it fixes your problem I'll > send a clean patch. Broken by: commit 52929715634ad36782bd7018ab0bf59a6619c393 Author: Guenter Roeck <linux@roeck-us.net> Date: Sat Mar 30 14:00:08 2013 -0700 hwmon: (it87) Use is_visible for voltage sensors Only kernel v4.7 is affected. I'll send a clean patch after my lunch.
On Mon, Aug 29, 2016 at 1:11 PM, Jean Delvare <jdelvare@suse.de> wrote: > On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: >> I'm trying to find when the bug was introduced. I have a hard time >> believing it went unnoticed for long. If it fixes your problem I'll >> send a clean patch. > > Broken by: > > commit 52929715634ad36782bd7018ab0bf59a6619c393 > Author: Guenter Roeck <linux@roeck-us.net> > Date: Sat Mar 30 14:00:08 2013 -0700 > > hwmon: (it87) Use is_visible for voltage sensors > > Only kernel v4.7 is affected. I'll send a clean patch after my lunch. > > -- > Jean Delvare > SUSE L3 Support Hello Jean, Thanks very much for your response. I am away from my PC at the moment, so I cannot try out your proposed fix. I would be able to do so at my earliest convenience, and let you know how I went, i.e. if you still want me to try it out. Alexander. -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/29/2016 03:11 AM, Jean Delvare wrote: > On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: >> I'm trying to find when the bug was introduced. I have a hard time >> believing it went unnoticed for long. If it fixes your problem I'll >> send a clean patch. > > Broken by: > > commit 52929715634ad36782bd7018ab0bf59a6619c393 > Author: Guenter Roeck <linux@roeck-us.net> > Date: Sat Mar 30 14:00:08 2013 -0700 > > hwmon: (it87) Use is_visible for voltage sensors > Yes. Oops, I should know better. Thanks for picking this up so quickly. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 29 Aug 2016 07:46:36 -0700, Guenter Roeck wrote: > On 08/29/2016 03:11 AM, Jean Delvare wrote: > > On Mon, 29 Aug 2016 12:06:34 +0200, Jean Delvare wrote: > >> I'm trying to find when the bug was introduced. I have a hard time > >> believing it went unnoticed for long. If it fixes your problem I'll > >> send a clean patch. > > > > Broken by: > > > > commit 52929715634ad36782bd7018ab0bf59a6619c393 > > Author: Guenter Roeck <linux@roeck-us.net> > > Date: Sat Mar 30 14:00:08 2013 -0700 > > > > hwmon: (it87) Use is_visible for voltage sensors > > > Yes. Oops, I should know better. Thanks for picking this up so quickly. You're welcome. This is my punishment for not reviewing the patches as you post them...
--- linux-4.7.orig/drivers/hwmon/it87.c 2016-07-04 08:01:00.000000000 +0200 +++ linux-4.7/drivers/hwmon/it87.c 2016-08-29 12:04:52.926911625 +0200 @@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes &sensor_dev_attr_in10_input.dev_attr.attr, /* 41 */ &sensor_dev_attr_in11_input.dev_attr.attr, /* 41 */ &sensor_dev_attr_in12_input.dev_attr.attr, /* 41 */ + NULL }; static const struct attribute_group it87_group_in = {
Hello Alexander, On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote: > I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details: it87_attributes_in lacks its NULL terminator, looks suspicious to me. Can you try the following quick fix? --- drivers/hwmon/it87.c | 1 + 1 file changed, 1 insertion(+) I'm trying to find when the bug was introduced. I have a hard time believing it went unnoticed for long. If it fixes your problem I'll send a clean patch.