From patchwork Mon Aug 29 10:06:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 9303409 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51124601C0 for ; Mon, 29 Aug 2016 10:06:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40D272847F for ; Mon, 29 Aug 2016 10:06:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34F34286CB; Mon, 29 Aug 2016 10:06:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFA2A2847F for ; Mon, 29 Aug 2016 10:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756135AbcH2KGi (ORCPT ); Mon, 29 Aug 2016 06:06:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:37197 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756125AbcH2KGi (ORCPT ); Mon, 29 Aug 2016 06:06:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 554A9AD5D; Mon, 29 Aug 2016 10:06:36 +0000 (UTC) Date: Mon, 29 Aug 2016 12:06:34 +0200 From: Jean Delvare To: Alexander Kapshuk Cc: linux-hwmon@vger.kernel.org, linux-kernel Subject: Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER Message-ID: <20160829120634.039204a6@endymion> In-Reply-To: References: Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.30; x86_64-suse-linux-gnu) MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Alexander, On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote: > I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details: it87_attributes_in lacks its NULL terminator, looks suspicious to me. Can you try the following quick fix? --- drivers/hwmon/it87.c | 1 + 1 file changed, 1 insertion(+) I'm trying to find when the bug was introduced. I have a hard time believing it went unnoticed for long. If it fixes your problem I'll send a clean patch. --- linux-4.7.orig/drivers/hwmon/it87.c 2016-07-04 08:01:00.000000000 +0200 +++ linux-4.7/drivers/hwmon/it87.c 2016-08-29 12:04:52.926911625 +0200 @@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes &sensor_dev_attr_in10_input.dev_attr.attr, /* 41 */ &sensor_dev_attr_in11_input.dev_attr.attr, /* 41 */ &sensor_dev_attr_in12_input.dev_attr.attr, /* 41 */ + NULL }; static const struct attribute_group it87_group_in = {