From patchwork Sun Mar 12 13:25:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 9619385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 67548604CC for ; Sun, 12 Mar 2017 13:25:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5731F2833C for ; Sun, 12 Mar 2017 13:25:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B5FA2845C; Sun, 12 Mar 2017 13:25:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A59962833C for ; Sun, 12 Mar 2017 13:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755750AbdCLNZt (ORCPT ); Sun, 12 Mar 2017 09:25:49 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:54117 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755744AbdCLNZs (ORCPT ); Sun, 12 Mar 2017 09:25:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=In-Reply-To:Content-Type:MIME-Version:References :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gtX+RhmZBhy+zCWTa9jSy1rWCdNMY6kZR+PzB/163Yo=; b=2D4JKaBQJ0oM9bQTXhDPix98aD i9MCHiHx9wfbuWPpb9VladTp/TeEYHPVaCsSSwr8UCZZdNA5L7ixe7cQHd40clzId0bJ2TNEctcQG 4pGNAt6G4oF2nTU0Ifi7JG+43lfOO0s5KnIyqRGLSwWU64Rbb3+T0eptTuVMWrGxS5NRz4UFz1Gf9 eOf1LOw6rKXmUrvDVb/rBBC+hxbnQoQD1UW4whsetpuBqYqIMCGjZQTajsU43PWs5YkWXuaJBv1fD NRUJH8OQknJ9gfr933kd+A8Llsrc0FH93bw9RHJX9hFJ93rJJ2z8O3+WCALXecyG8s/xeEFTm92J3 ZtKDHbFw==; Received: from 108-223-40-66.lightspeed.sntcca.sbcglobal.net ([108.223.40.66]:42412 helo=localhost) by bh-25.webhostbox.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cn3VL-002MDP-TB; Sun, 12 Mar 2017 13:25:48 +0000 Date: Sun, 12 Mar 2017 06:25:44 -0700 From: Guenter Roeck To: Russell King - ARM Linux Cc: Jean Delvare , linux-hwmon@vger.kernel.org Subject: Re: it87 causes VIA hardware to lockup Message-ID: <20170312132544.GA17687@roeck-us.net> References: <20170312103413.GJ21222@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170312103413.GJ21222@n2100.armlinux.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Mar 12, 2017 at 10:34:13AM +0000, Russell King - ARM Linux wrote: > Hi, > > I recently upgraded a machine that backs up data at a club from a > 2.6.30 based distribution to 4.8.0 based distribution, and I find > that modprobing the it87 sensor driver on 4.8.0 causes the machine > to lockup. > > Unfortunately, as far as I'm aware, there is no kernel oops or > kernel messages, it just locks the machine up such that it requires > a power cycle. > > With 2.6.30, it was possible to modprobe the driver and lm_sensors > would then read out the fan and temperature information (which is > necessary to monitor the head-less machine that is otherwise buried > in an area that hardly anyone goes.) > > it87-isa-0290 > Adapter: ISA adapter > in0: +1.60 V (min = +0.00 V, max = +4.08 V) > in1: +2.50 V (min = +0.00 V, max = +4.08 V) > in2: +3.34 V (min = +0.00 V, max = +4.08 V) > in3: +2.29 V (min = +0.00 V, max = +4.08 V) > in4: +3.14 V (min = +0.00 V, max = +4.08 V) > in5: +2.72 V (min = +0.00 V, max = +4.08 V) > in6: +2.11 V (min = +0.00 V, max = +4.08 V) > in7: +2.10 V (min = +0.00 V, max = +4.08 V) > Vbat: +0.00 V > fan1: 3245 RPM (min = 0 RPM, div = 8) > fan2: 0 RPM (min = 0 RPM, div = 8) > temp1: +9.0 C (low = +127.0 C, high = +127.0 C) sensor = thermistor > temp2: +5.0 C (low = +127.0 C, high = +127.0 C) sensor = thermistor > temp3: +27.0 C (low = +127.0 C, high = +127.0 C) sensor = thermal diode > > Looking at the changes between the two kernels, I'd imagine that > unconditionally touching the registers at 0x4e/0x4f (which the > driver never used to do) is upsetting the bridges, causing the > machine to lock up. > I found some reference suggesting that The IT8705F may respond on both SIO addresses. Can you try the following patch ? Guenter --- From 97ec1bb3274914b07ffb01a2c5d3501fee9af8c4 Mon Sep 17 00:00:00 2001 From: Guenter Roeck Date: Sun, 12 Mar 2017 06:18:58 -0700 Subject: [PATCH] hwmon: (it87) Don't check second SIO address for older chips IT8705F is known to respond on both SIO addresses. Stop scanning for chips after finding one. Fixes: e84bd9535e2b ("hwmon: (it87) Add support for second Super-IO chip") Signed-off-by: Guenter Roeck --- drivers/hwmon/it87.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index 3e57a6120551..cce0683cf2fd 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3215,7 +3215,15 @@ static int __init sm_it87_init(void) err = it87_device_add(i, isa_address, &sio_data); if (err) goto exit_dev_unregister; + found = true; + + /* + * Don't continue searching after finding an older chip + * which may respond on both SIO addresses. + */ + if (sio_data.type == it87) + break; } if (!found) {