| Message ID | 20170427153012.32310-4-sebastian.reichel@collabora.co.uk (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 27/04/17 16:30, Sebastian Reichel wrote: > Drop legacy twl4030_get_madc_conversion() method. It has been > used by drivers to get madc data before it conversion to IIO > API. There are no users in the mainline kernel anymore. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Acked-by: Jonathan Cameron <jic23@kernel.org> > --- > drivers/iio/adc/twl4030-madc.c | 21 --------------------- > include/linux/i2c/twl4030-madc.h | 1 - > 2 files changed, 22 deletions(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 0c74869a540a..88e44066ef82 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -642,27 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) > } > EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > -int twl4030_get_madc_conversion(int channel_no) > -{ > - struct twl4030_madc_request req; > - int temp = 0; > - int ret; > - > - req.channels = (1 << channel_no); > - req.method = TWL4030_MADC_SW2; > - req.active = 0; > - req.raw = 0; > - req.func_cb = NULL; > - ret = twl4030_madc_conversion(&req); > - if (ret < 0) > - return ret; > - if (req.rbuf[channel_no] > 0) > - temp = req.rbuf[channel_no]; > - > - return temp; > -} > -EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); > - > /** > * twl4030_madc_set_current_generator() - setup bias current > * > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h > index 1c0134dd3271..0c919ebb31e0 100644 > --- a/include/linux/i2c/twl4030-madc.h > +++ b/include/linux/i2c/twl4030-madc.h > @@ -143,5 +143,4 @@ struct twl4030_madc_user_parms { > }; > > int twl4030_madc_conversion(struct twl4030_madc_request *conv); > -int twl4030_get_madc_conversion(int channel_no); > #endif > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 30 Apr 2017 17:35:04 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > On 27/04/17 16:30, Sebastian Reichel wrote: > > Drop legacy twl4030_get_madc_conversion() method. It has been > > used by drivers to get madc data before it conversion to IIO > > API. There are no users in the mainline kernel anymore. > > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> > Acked-by: Jonathan Cameron <jic23@kernel.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > --- > > drivers/iio/adc/twl4030-madc.c | 21 --------------------- > > include/linux/i2c/twl4030-madc.h | 1 - > > 2 files changed, 22 deletions(-) > > > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > > index 0c74869a540a..88e44066ef82 100644 > > --- a/drivers/iio/adc/twl4030-madc.c > > +++ b/drivers/iio/adc/twl4030-madc.c > > @@ -642,27 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) > > } > > EXPORT_SYMBOL_GPL(twl4030_madc_conversion); > > > > -int twl4030_get_madc_conversion(int channel_no) > > -{ > > - struct twl4030_madc_request req; > > - int temp = 0; > > - int ret; > > - > > - req.channels = (1 << channel_no); > > - req.method = TWL4030_MADC_SW2; > > - req.active = 0; > > - req.raw = 0; > > - req.func_cb = NULL; > > - ret = twl4030_madc_conversion(&req); > > - if (ret < 0) > > - return ret; > > - if (req.rbuf[channel_no] > 0) > > - temp = req.rbuf[channel_no]; > > - > > - return temp; > > -} > > -EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); > > - > > /** > > * twl4030_madc_set_current_generator() - setup bias current > > * > > diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h > > index 1c0134dd3271..0c919ebb31e0 100644 > > --- a/include/linux/i2c/twl4030-madc.h > > +++ b/include/linux/i2c/twl4030-madc.h > > @@ -143,5 +143,4 @@ struct twl4030_madc_user_parms { > > }; > > > > int twl4030_madc_conversion(struct twl4030_madc_request *conv); > > -int twl4030_get_madc_conversion(int channel_no); > > #endif > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c index 0c74869a540a..88e44066ef82 100644 --- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -642,27 +642,6 @@ int twl4030_madc_conversion(struct twl4030_madc_request *req) } EXPORT_SYMBOL_GPL(twl4030_madc_conversion); -int twl4030_get_madc_conversion(int channel_no) -{ - struct twl4030_madc_request req; - int temp = 0; - int ret; - - req.channels = (1 << channel_no); - req.method = TWL4030_MADC_SW2; - req.active = 0; - req.raw = 0; - req.func_cb = NULL; - ret = twl4030_madc_conversion(&req); - if (ret < 0) - return ret; - if (req.rbuf[channel_no] > 0) - temp = req.rbuf[channel_no]; - - return temp; -} -EXPORT_SYMBOL_GPL(twl4030_get_madc_conversion); - /** * twl4030_madc_set_current_generator() - setup bias current * diff --git a/include/linux/i2c/twl4030-madc.h b/include/linux/i2c/twl4030-madc.h index 1c0134dd3271..0c919ebb31e0 100644 --- a/include/linux/i2c/twl4030-madc.h +++ b/include/linux/i2c/twl4030-madc.h @@ -143,5 +143,4 @@ struct twl4030_madc_user_parms { }; int twl4030_madc_conversion(struct twl4030_madc_request *conv); -int twl4030_get_madc_conversion(int channel_no); #endif
Drop legacy twl4030_get_madc_conversion() method. It has been used by drivers to get madc data before it conversion to IIO API. There are no users in the mainline kernel anymore. Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> --- drivers/iio/adc/twl4030-madc.c | 21 --------------------- include/linux/i2c/twl4030-madc.h | 1 - 2 files changed, 22 deletions(-)