| Message ID | 20170621000309.18234-1-venture@google.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 86e2ea8287a7..b2ab5612d8a4 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -160,7 +160,7 @@ * 11: reserved. */ #define M_TACH_MODE 0x02 /* 10b */ -#define M_TACH_UNIT 0x1000 +#define M_TACH_UNIT 0x00c0 #define INIT_FAN_CTRL 0xFF struct aspeed_pwm_tacho_data {
Through testing a variety of fan_tach values 0xc0 was found to provide ideal fan_tach read performance. The fans were also as responsive to speed changes as desired. This is part of a performance tweak for the responsiveness of the driver. Tested: This was tested on the Quanta-Q71l via aspeed ast2400. Caveat: I found that if a fan is broken this fan_tach period is too short if used to get a reliable response and ETIMEDOUT will return. I also found that if I set a fan's PWM to below 30% it would have a similar issue returning the fan_tach. However, that was in combination with another patch that mimics the reference driver behavior that no longer sleeps. In our DCs, we never expect to run fans below this threshold and it increases the responsiveness of the read fan_tach response. If suggested, we could move these knobs into device-trees or allow device-tree overrides to these defaults with very few edits. Signed-off-by: Patrick Venture <venture@google.com> --- drivers/hwmon/aspeed-pwm-tacho.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)