diff mbox

[PATCHv4,3/4] dt-bindings: mfd: da9052: support TSI as ADC

Message ID 20170630143506.10541-4-sebastian.reichel@collabora.co.uk (mailing list archive)
State Superseded
Headers show

Commit Message

Sebastian Reichel June 30, 2017, 2:35 p.m. UTC
DA9052 allows using the touchscreen input pins as general purpose
analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y-
and providing a reference voltage at TSIREF pin.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
---
 Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Lee Jones July 17, 2017, 10:49 a.m. UTC | #1
On Fri, 30 Jun 2017, Sebastian Reichel wrote:

> DA9052 allows using the touchscreen input pins as general purpose
> analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y-
> and providing a reference voltage at TSIREF pin.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
>  Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> index 9554292dc6cb..57fa74e65664 100644
> --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> @@ -4,6 +4,14 @@ Required properties:
>  - compatible : Should be "dlg,da9052", "dlg,da9053-aa",
>  			 "dlg,da9053-ab", or "dlg,da9053-bb"
>  
> +Optional properties:
> +- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
> +                    input lines are used as general purpose analogue
> +					input.
> +- tsiref-supply: Phandle to the regulator, which provides the reference
> +                 voltage for the TSIREF pin. Must be provided when the
> +			     touchscreen pins are used for ADC purposes.
> +

DT Ack please.
Sebastian Reichel July 17, 2017, 11:27 a.m. UTC | #2
Hi Lee,

On Mon, Jul 17, 2017 at 11:49:45AM +0100, Lee Jones wrote:
> On Fri, 30 Jun 2017, Sebastian Reichel wrote:
> 
> > DA9052 allows using the touchscreen input pins as general purpose
> > analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y-
> > and providing a reference voltage at TSIREF pin.
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> > ---
> >  Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > index 9554292dc6cb..57fa74e65664 100644
> > --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > +++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
> > @@ -4,6 +4,14 @@ Required properties:
> >  - compatible : Should be "dlg,da9052", "dlg,da9053-aa",
> >  			 "dlg,da9053-ab", or "dlg,da9053-bb"
> >  
> > +Optional properties:
> > +- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
> > +                    input lines are used as general purpose analogue
> > +					input.
> > +- tsiref-supply: Phandle to the regulator, which provides the reference
> > +                 voltage for the TSIREF pin. Must be provided when the
> > +			     touchscreen pins are used for ADC purposes.
> > +
> 
> DT Ack please.

There is a v5 of this series, which has Acked-by from Rob already
and got positive feedback from Guenter Roeck for the hwmon parts:

http://lkml.iu.edu/hypermail/linux/kernel/1707.0/00518.html

(if you received v4, v5 should also be in your INBOX)

-- Sebastian
Guenter Roeck July 22, 2017, 3:09 p.m. UTC | #3
On 07/17/2017 04:27 AM, Sebastian Reichel wrote:
> Hi Lee,
> 
> On Mon, Jul 17, 2017 at 11:49:45AM +0100, Lee Jones wrote:
>> On Fri, 30 Jun 2017, Sebastian Reichel wrote:
>>
>>> DA9052 allows using the touchscreen input pins as general purpose
>>> analogue input pin by wiring analogue inputs to X+, X-, Y+ and Y-
>>> and providing a reference voltage at TSIREF pin.
>>>
>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>>> ---
>>>   Documentation/devicetree/bindings/mfd/da9052-i2c.txt | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> index 9554292dc6cb..57fa74e65664 100644
>>> --- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> +++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
>>> @@ -4,6 +4,14 @@ Required properties:
>>>   - compatible : Should be "dlg,da9052", "dlg,da9053-aa",
>>>   			 "dlg,da9053-ab", or "dlg,da9053-bb"
>>>   
>>> +Optional properties:
>>> +- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
>>> +                    input lines are used as general purpose analogue
>>> +					input.
>>> +- tsiref-supply: Phandle to the regulator, which provides the reference
>>> +                 voltage for the TSIREF pin. Must be provided when the
>>> +			     touchscreen pins are used for ADC purposes.
>>> +
>>
>> DT Ack please.
> 
> There is a v5 of this series, which has Acked-by from Rob already
> and got positive feedback from Guenter Roeck for the hwmon parts:
> 
> http://lkml.iu.edu/hypermail/linux/kernel/1707.0/00518.html
> 
> (if you received v4, v5 should also be in your INBOX)
> 

Yes, but you dropped all the Acks in v6. That is supposed to mean that there
was a substantial change to the patch, and that it needs to be re-reviewed.
For the hwmon patches, I ran a diff against v5 and noticed that there was no
change between v5 and v6, yet you dropped my Acks. Do you really expect us
to do all that work on your behalf ?

Sorry if I sound a bit annoyed. That is because I _am_ a bit annoyed.
Please keep in mind that you are taking our time.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Reichel July 22, 2017, 7:08 p.m. UTC | #4
Hi,

On Sat, Jul 22, 2017 at 08:09:08AM -0700, Guenter Roeck wrote:
> Yes, but you dropped all the Acks in v6. That is supposed to mean that there
> was a substantial change to the patch, and that it needs to be re-reviewed.
> For the hwmon patches, I ran a diff against v5 and noticed that there was no
> change between v5 and v6, yet you dropped my Acks. Do you really expect us
> to do all that work on your behalf ?
> 
> Sorry if I sound a bit annoyed. That is because I _am_ a bit annoyed.
> Please keep in mind that you are taking our time.

FWIW, I did not drop them, but forgot to add the ones I received in
PATCHv5. Mainly since I initially did not plan to resend the whole
patchset, but then decided otherwise.

Sorry anyways.

-- Sebastian
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
index 9554292dc6cb..57fa74e65664 100644
--- a/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
+++ b/Documentation/devicetree/bindings/mfd/da9052-i2c.txt
@@ -4,6 +4,14 @@  Required properties:
 - compatible : Should be "dlg,da9052", "dlg,da9053-aa",
 			 "dlg,da9053-ab", or "dlg,da9053-bb"
 
+Optional properties:
+- dlg,tsi-as-adc : Boolean, if set the X+, X-, Y+, Y- touchscreen
+                    input lines are used as general purpose analogue
+					input.
+- tsiref-supply: Phandle to the regulator, which provides the reference
+                 voltage for the TSIREF pin. Must be provided when the
+			     touchscreen pins are used for ADC purposes.
+
 Sub-nodes:
 - regulators : Contain the regulator nodes. The DA9052/53 regulators are
   bound using their names as listed below: