From patchwork Tue Aug 15 14:47:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9902003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7E85A60230 for ; Tue, 15 Aug 2017 14:51:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7144927F82 for ; Tue, 15 Aug 2017 14:51:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6612927FB6; Tue, 15 Aug 2017 14:51:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6175627E71 for ; Tue, 15 Aug 2017 14:51:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbdHOOux (ORCPT ); Tue, 15 Aug 2017 10:50:53 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54051 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbdHOOuw (ORCPT ); Tue, 15 Aug 2017 10:50:52 -0400 Received: from wuerfel.lan ([95.208.155.18]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.129]) with ESMTPA (Nemesis) id 0M4NmW-1dP9M12xnY-00yf2l; Tue, 15 Aug 2017 16:49:01 +0200 From: Arnd Bergmann To: Jean Delvare , Guenter Roeck Cc: Arnd Bergmann , Jaghathiswari Rankappagounder Natarajan , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: aspeed: add THERMAL dependency Date: Tue, 15 Aug 2017 16:47:47 +0200 Message-Id: <20170815144856.2059759-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:kqnMG4+yArTGnNzJTVDAoGLP2ylvdBK+F4dKbqoJ+Ku1zz+OrkW ELc+xDJ1wLQ1UF2PrxuBTo8xYoYtYIghoWr8Levs+670ICRdBgxlGsizY04xtrM8qI54QeQ NGRFowgGoyLa1gRVaRdSv46dKoOmvYK2M4XNIwsIK4C+N2u2c72ZA342piO51nnfg0Nmue1 MdGFxazyT1Bbgzf8EEtUQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:PakWSDuan5g=:BbB1sAd+dUx4rfSIm4y6Jc FMhFCr0UG/e/Ewzoe4M9+pTE19yhD+pdUlz/IsHT4liRYDrAeXO1BRkMpzvYJIlkaFcK0JSeR 7S8/2wrOHsLZieVK0rem/UNvI/A88n848NSaIT6nIISxsZ3OE5ozqIR43dqBmd8DcLJ8nResg akmqDysfN88mJglJbHerxjTvulyq4UBvSO7TYu3WFrLPBMhDm7YE/iTYkUw3g814WgrWgjV5s zROR+he75V3nzDEgMRnO6HHlC23QmF/krhc8CzcqC1xNOOTy8FbTQWjnGqGb0c+JIAsohdPR4 oMdqVZHRmIUV/tVXtygBwFIehlTxHaI+tv2i2loX7sGI1fcDDdDZAQ9J0Uiezc+8Rr7oWn5mm 47gymJKvc1cHr2grcwjktGFoQ4rRc1H2AEoqMcI7Ei8YAXUVLEfJbFK+9ab5Fn0vZH2d9TwFe kwyGbgsfElR30F3dffGx6reYZ6WrXweG+IVxtelXf5PFYD4YnwjUAa4cDreUomc/flkiE7wHg HVsf+K7RvC/40Hu4Eihj4/ytmmOOFTSB8y38PCW2tX5HpZaVZOcKF7EPGAglwE1Kq0KxgbaJt TC1fyL+TJ/3vGAQOtwG+01hO8ZSiGicQ9lCYJizF4x5pJj0VledNrGcM58KWIdlzRRcckIXEj VtoFl6cpxiPuwtvUZO3J+rf6rWaQfCRfq1NcVZN6BAcf5zuMDsk/P0Cp4M9KsdMSHjkqRz9k4 Q+/qyyfwlQWMdJN2UtncuHO0/anvGENeG14T5Q== Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With CONFIG_THERMAL=m, a built-in aspeed pwm tacho driver causes a link error: drivers/hwmon/aspeed-pwm-tacho.o: In function `aspeed_pwm_tacho_probe': aspeed-pwm-tacho.c:(.text+0x7f0): undefined reference to `thermal_of_cooling_device_register' This adds a dependency similar to what other hwmon drivers use, ensuring that the aspeed driver cannot be built-in in this case but has to be a module. With THERMAL=n, we still allow building it. Fixes: 2d7a548a3eff ("drivers: hwmon: Support for ASPEED PWM/Fan tach") Signed-off-by: Arnd Bergmann --- drivers/hwmon/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index 5ef2814345ef..5b9a61f766ac 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -343,6 +343,7 @@ config SENSORS_ASB100 config SENSORS_ASPEED tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver" + depends on THERMAL || THERMAL=n select REGMAP help This driver provides support for ASPEED AST2400/AST2500 PWM