| Message ID | 20180720230212.26006-1-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
On 07/20/2018 04:02 PM, Peter Robinson wrote: > The raspberrypi-hwmon driver doesn't automatically load, although it does work > when loaded, by adding the alias it auto loads as expected when built as a > module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with > Fedora 28 and a patched 4.18 RC kernel. > > Fixes: q3c493c885cf ("hwmon: Add support for RPi voltage sensor") > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > CC: Stefan Wahren <stefan.wahren@i2se.com> > CC: Eric Anholt <eric@anholt.net> Acked-by: Guenter Roeck <linux@roeck-us.net> Florian, I think the driver is in your tree - can you take this patch ? Thanks, Guenter > --- > drivers/hwmon/raspberrypi-hwmon.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/raspberrypi-hwmon.c b/drivers/hwmon/raspberrypi-hwmon.c > index fb4e4a6bb1f63..be5ba46908953 100644 > --- a/drivers/hwmon/raspberrypi-hwmon.c > +++ b/drivers/hwmon/raspberrypi-hwmon.c > @@ -164,3 +164,4 @@ module_platform_driver(rpi_hwmon_driver); > MODULE_AUTHOR("Stefan Wahren <stefan.wahren@i2se.com>"); > MODULE_DESCRIPTION("Raspberry Pi voltage sensor driver"); > MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:raspberrypi-hwmon"); > -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> Peter Robinson <pbrobinson@gmail.com> hat am 21. Juli 2018 um 01:02 geschrieben: > > > The raspberrypi-hwmon driver doesn't automatically load, although it does work > when loaded, by adding the alias it auto loads as expected when built as a > module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with > Fedora 28 and a patched 4.18 RC kernel. > > Fixes: q3c493c885cf ("hwmon: Add support for RPi voltage sensor") > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > CC: Stefan Wahren <stefan.wahren@i2se.com> > CC: Eric Anholt <eric@anholt.net> > --- Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Guenter Roeck <linux@roeck-us.net> writes: > On 07/20/2018 04:02 PM, Peter Robinson wrote: >> The raspberrypi-hwmon driver doesn't automatically load, although it does work >> when loaded, by adding the alias it auto loads as expected when built as a >> module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with >> Fedora 28 and a patched 4.18 RC kernel. >> >> Fixes: q3c493c885cf ("hwmon: Add support for RPi voltage sensor") >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> CC: Stefan Wahren <stefan.wahren@i2se.com> >> CC: Eric Anholt <eric@anholt.net> > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > Florian, I think the driver is in your tree - can you take this patch ? Florian's been on vacation for a bit, but hopefully when he gets back (next week, iirc?) he can just apply it with my r-b as well :) Thanks, Peter!
On 07/20/2018 09:24 PM, Guenter Roeck wrote: > On 07/20/2018 04:02 PM, Peter Robinson wrote: >> The raspberrypi-hwmon driver doesn't automatically load, although it >> does work >> when loaded, by adding the alias it auto loads as expected when built >> as a >> module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with >> Fedora 28 and a patched 4.18 RC kernel. >> >> Fixes: q3c493c885cf ("hwmon: Add support for RPi voltage sensor") >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> CC: Stefan Wahren <stefan.wahren@i2se.com> >> CC: Eric Anholt <eric@anholt.net> > > Acked-by: Guenter Roeck <linux@roeck-us.net> > > Florian, I think the driver is in your tree - can you take this patch ? Yes, now applied to drivers/next, thanks for your patience, I was on holiday for quite a while.
diff --git a/drivers/hwmon/raspberrypi-hwmon.c b/drivers/hwmon/raspberrypi-hwmon.c index fb4e4a6bb1f63..be5ba46908953 100644 --- a/drivers/hwmon/raspberrypi-hwmon.c +++ b/drivers/hwmon/raspberrypi-hwmon.c @@ -164,3 +164,4 @@ module_platform_driver(rpi_hwmon_driver); MODULE_AUTHOR("Stefan Wahren <stefan.wahren@i2se.com>"); MODULE_DESCRIPTION("Raspberry Pi voltage sensor driver"); MODULE_LICENSE("GPL v2"); +MODULE_ALIAS("platform:raspberrypi-hwmon");
The raspberrypi-hwmon driver doesn't automatically load, although it does work when loaded, by adding the alias it auto loads as expected when built as a module. Tested on RPi2/RPi3 on 32 bit kernel and RPi3B+ on aarch64 with Fedora 28 and a patched 4.18 RC kernel. Fixes: q3c493c885cf ("hwmon: Add support for RPi voltage sensor") Signed-off-by: Peter Robinson <pbrobinson@gmail.com> CC: Stefan Wahren <stefan.wahren@i2se.com> CC: Eric Anholt <eric@anholt.net> --- drivers/hwmon/raspberrypi-hwmon.c | 1 + 1 file changed, 1 insertion(+)