| Message ID | 20180905074627.putclq3777lmxvoe@kili.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] hwmon: (nct6775) Set weight source to zero correctly | expand |
On Wed, Sep 05, 2018 at 10:46:27AM +0300, Dan Carpenter wrote: > This is dead code because j can never be 1 at this point. We had > intended to just test if the bit was clear. > > Fixes: bbd8decd4123 ("hwmon: (nct6775) Add support for weighted fan control") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied. Thanks, Guenter > > diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c > index 944f5b63aecd..139781ae830b 100644 > --- a/drivers/hwmon/nct6775.c > +++ b/drivers/hwmon/nct6775.c > @@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev) > reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]); > data->pwm_weight_temp_sel[i] = reg & 0x1f; > /* If weight is disabled, report weight source as 0 */ > - if (j == 1 && !(reg & 0x80)) > + if (!(reg & 0x80)) > data->pwm_weight_temp_sel[i] = 0; > > /* Weight temp data */
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 944f5b63aecd..139781ae830b 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -1558,7 +1558,7 @@ static void nct6775_update_pwm(struct device *dev) reg = nct6775_read_value(data, data->REG_WEIGHT_TEMP_SEL[i]); data->pwm_weight_temp_sel[i] = reg & 0x1f; /* If weight is disabled, report weight source as 0 */ - if (j == 1 && !(reg & 0x80)) + if (!(reg & 0x80)) data->pwm_weight_temp_sel[i] = 0; /* Weight temp data */
This is dead code because j can never be 1 at this point. We had intended to just test if the bit was clear. Fixes: bbd8decd4123 ("hwmon: (nct6775) Add support for weighted fan control") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>