diff mbox series

hwmon (lm63) Do not overwrite data->kind

Message ID 20181113043656.25765-1-nicoleotsuka@gmail.com (mailing list archive)
State Accepted
Headers show
Series hwmon (lm63) Do not overwrite data->kind | expand

Commit Message

Nicolin Chen Nov. 13, 2018, 4:36 a.m. UTC 
According to the code right before the removed line, data->kind
should be either from DT or from id pointer. So there shouldn't
be an additional overwriting after the if-else statement.

So this patch just removes the overwriting line.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
Guenter,
    I have not really tested this change but still sent it out
    since it looks obvious. Please feel free to drop it if you
    have concern at an untested change. Thanks.

 drivers/hwmon/lm63.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 4c1770920d29..eac54b9cdeec 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -1120,7 +1120,6 @@  static int lm63_probe(struct i2c_client *client,
 		data->kind = (enum chips)of_device_get_match_data(&client->dev);
 	else
 		data->kind = id->driver_data;
-	data->kind = id->driver_data;
 	if (data->kind == lm64)
 		data->temp2_offset = 16000;