From patchwork Thu Jun 6 12:38:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10979497 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EEB5576 for ; Thu, 6 Jun 2019 12:39:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE13B28815 for ; Thu, 6 Jun 2019 12:39:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2A6A288BC; Thu, 6 Jun 2019 12:39:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8374828346 for ; Thu, 6 Jun 2019 12:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbfFFMjC (ORCPT ); Thu, 6 Jun 2019 08:39:02 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:51352 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfFFMjC (ORCPT ); Thu, 6 Jun 2019 08:39:02 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hYrfU-0005oo-W8; Thu, 06 Jun 2019 12:38:57 +0000 From: Colin King To: "amy . shih" , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: nct7904: fix comparison of u8 variable ret with less than zero Date: Thu, 6 Jun 2019 13:38:56 +0100 Message-Id: <20190606123856.18531-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King Currently u8 variable tmp is being checked for negative error returns however this will be false since tmp is unsigned. Fix this by making tmp an int. Addresses-Coverity: ("Unsigned compared against 0") Fixes: af55ab0b0792 ("hwmon: (nct7904) Add extra sysfs support for fan, voltage and temperature.") Signed-off-by: Colin Ian King --- drivers/hwmon/nct7904.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c index 5fa69898674c..b63f51d0378e 100644 --- a/drivers/hwmon/nct7904.c +++ b/drivers/hwmon/nct7904.c @@ -567,8 +567,7 @@ static int nct7904_write_in(struct device *dev, u32 attr, int channel, long val) { struct nct7904_data *data = dev_get_drvdata(dev); - int ret, index; - u8 tmp; + int ret, index, tmp; index = nct7904_chan_to_index[channel];