From patchwork Thu Jun 27 15:27:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabian Schindlatz X-Patchwork-Id: 11019901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 874881398 for ; Thu, 27 Jun 2019 15:27:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 782331FE8B for ; Thu, 27 Jun 2019 15:27:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 69FC31FF0B; Thu, 27 Jun 2019 15:27:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E4C591FE8B for ; Thu, 27 Jun 2019 15:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbfF0P16 (ORCPT ); Thu, 27 Jun 2019 11:27:58 -0400 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:44159 "EHLO mx-rz-1.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfF0P16 (ORCPT ); Thu, 27 Jun 2019 11:27:58 -0400 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-1.rrze.uni-erlangen.de (Postfix) with ESMTPS id 45ZP0r1MlTz8srH; Thu, 27 Jun 2019 17:27:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fau.de; s=fau-2013; t=1561649276; bh=Zd6DDfelGcmi1TCNL0D5BdOsmsLlB086IqcwKZ3A8U0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:To:CC: Subject; b=bf7iNudIBz+JTRTSAUqT95wlDFCORL7gaEHak8EaE+0t8bIkdtKVEERvKwK4+fFG7 BHbaFOuieXqeOo5uevmCraDwbFtI6fqqpbZJSWhOmhoWLP49z7Dv93fJWJUgZNtv6e 1OkZkFtOpzC1Q2Xr5J3VyE+Za05Z9D+vbeynnYe7+LYrAPubdtPU7gs6V3Bk3QWjEM 9ggr/o9PHS/8aN80P4WNiDWTUKHVNb/6rK4xM/QOjuvRZAOrDEmlb9pDtJ/V3cw2X/ hgYlcK2ElaAOFnnE/jsxbTwSe142wc3jLZZc3uphqV4mJpelDNwlshaEwC6XSAi7cp 7cItgGGmGDR8Q== X-Virus-Scanned: amavisd-new at boeck4.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 10.21.35.53 Received: from laptop.pool.uni-erlangen.de (faustud-010-021-035-053.pool.uni-erlangen.de [10.21.35.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX1/ZqR2GOQ1IngWZuCo+nC2TA8OO1yZ0bGs=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 45ZP0n57wvz8tLT; Thu, 27 Jun 2019 17:27:53 +0200 (CEST) From: Fabian Schindlatz To: Jean Delvare , Guenter Roeck , Fenghua Yu , Rudolf Marek , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Fabian Schindlatz , =?utf-8?q?Thomas_R=C3=B6th?= =?utf-8?q?enbacher?= , linux-kernel@i4.cs.fau.de Subject: [PATCH v2] hwmon: Correct struct allocation style Date: Thu, 27 Jun 2019 17:27:38 +0200 Message-Id: <20190627152738.29645-1-fabian.schindlatz@fau.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <9160e7fe-7229-a097-48f7-d882cc760b53@roeck-us.net> References: <9160e7fe-7229-a097-48f7-d882cc760b53@roeck-us.net> MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use sizeof(*var) instead of sizeof(struct var_type) as argument to kalloc() and friends to comply with the kernel coding style. Co-developed-by: Thomas Röthenbacher Signed-off-by: Thomas Röthenbacher Signed-off-by: Fabian Schindlatz Cc: linux-kernel@i4.cs.fau.de --- drivers/hwmon/acpi_power_meter.c | 3 +-- drivers/hwmon/coretemp.c | 4 ++-- drivers/hwmon/fschmd.c | 2 +- drivers/hwmon/sch56xx-common.c | 2 +- drivers/hwmon/via-cputemp.c | 5 ++--- drivers/hwmon/w83793.c | 2 +- 6 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/hwmon/acpi_power_meter.c b/drivers/hwmon/acpi_power_meter.c index 6ba1a08253f0..48c4570c61d7 100644 --- a/drivers/hwmon/acpi_power_meter.c +++ b/drivers/hwmon/acpi_power_meter.c @@ -862,8 +862,7 @@ static int acpi_power_meter_add(struct acpi_device *device) if (!device) return -EINVAL; - resource = kzalloc(sizeof(struct acpi_power_meter_resource), - GFP_KERNEL); + resource = kzalloc(sizeof(*resource), GFP_KERNEL); if (!resource) return -ENOMEM; diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index fe6618e49dc4..0361115d25dd 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -433,7 +433,7 @@ static struct temp_data *init_temp_data(unsigned int cpu, int pkg_flag) { struct temp_data *tdata; - tdata = kzalloc(sizeof(struct temp_data), GFP_KERNEL); + tdata = kzalloc(sizeof(*tdata), GFP_KERNEL); if (!tdata) return NULL; @@ -532,7 +532,7 @@ static int coretemp_probe(struct platform_device *pdev) struct platform_data *pdata; /* Initialize the per-zone data structures */ - pdata = devm_kzalloc(dev, sizeof(struct platform_data), GFP_KERNEL); + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM; diff --git a/drivers/hwmon/fschmd.c b/drivers/hwmon/fschmd.c index fa0c2f1fb443..d464dcbe5ac8 100644 --- a/drivers/hwmon/fschmd.c +++ b/drivers/hwmon/fschmd.c @@ -1090,7 +1090,7 @@ static int fschmd_probe(struct i2c_client *client, int i, err; enum chips kind = id->driver_data; - data = kzalloc(sizeof(struct fschmd_data), GFP_KERNEL); + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) return -ENOMEM; diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c index 6c84780e358e..0d6d20814183 100644 --- a/drivers/hwmon/sch56xx-common.c +++ b/drivers/hwmon/sch56xx-common.c @@ -401,7 +401,7 @@ struct sch56xx_watchdog_data *sch56xx_watchdog_register(struct device *parent, return NULL; } - data = kzalloc(sizeof(struct sch56xx_watchdog_data), GFP_KERNEL); + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) return NULL; diff --git a/drivers/hwmon/via-cputemp.c b/drivers/hwmon/via-cputemp.c index 8264e849e588..0feb1d0b5e13 100644 --- a/drivers/hwmon/via-cputemp.c +++ b/drivers/hwmon/via-cputemp.c @@ -114,8 +114,7 @@ static int via_cputemp_probe(struct platform_device *pdev) int err; u32 eax, edx; - data = devm_kzalloc(&pdev->dev, sizeof(struct via_cputemp_data), - GFP_KERNEL); + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) return -ENOMEM; @@ -223,7 +222,7 @@ static int via_cputemp_online(unsigned int cpu) goto exit; } - pdev_entry = kzalloc(sizeof(struct pdev_entry), GFP_KERNEL); + pdev_entry = kzalloc(sizeof(*pdev_entry), GFP_KERNEL); if (!pdev_entry) { err = -ENOMEM; goto exit_device_put; diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c index 46f5dfec8d0a..b37106c6f26d 100644 --- a/drivers/hwmon/w83793.c +++ b/drivers/hwmon/w83793.c @@ -1669,7 +1669,7 @@ static int w83793_probe(struct i2c_client *client, int files_pwm = ARRAY_SIZE(w83793_left_pwm) / 5; int files_temp = ARRAY_SIZE(w83793_temp) / 6; - data = kzalloc(sizeof(struct w83793_data), GFP_KERNEL); + data = kzalloc(sizeof(*data), GFP_KERNEL); if (!data) { err = -ENOMEM; goto exit;