From patchwork Thu Aug 8 08:01:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 11083459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DEE15912 for ; Thu, 8 Aug 2019 08:01:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D23B0288A2 for ; Thu, 8 Aug 2019 08:01:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C59E428AF1; Thu, 8 Aug 2019 08:01:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FAD428AF1 for ; Thu, 8 Aug 2019 08:01:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731739AbfHHIB4 (ORCPT ); Thu, 8 Aug 2019 04:01:56 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39654 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfHHIBz (ORCPT ); Thu, 8 Aug 2019 04:01:55 -0400 Received: by mail-wr1-f65.google.com with SMTP id t16so3803640wra.6 for ; Thu, 08 Aug 2019 01:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vF1D4ziTGh7E6yjRLQ/d3L84V5Gio+kElGO9NUrx4Pk=; b=DgNS5ixrZp/5vInKyiSdL2c4KC6mFHmp/eEk4aheh1km4HVyaWFJatQavM/3DEQ5gO IQ/vslc/d09rfuHc0EH0jpptZwQCViSvvqJwnk4YFSJ24sLBsQXhuLY5qUHFPex2S2aZ yw6I9ar5EG1MfChGaXYGs+aM3Jidu4DavXgOU+CiJxyipMKIS4GOHbb4lc6FJ833OsUL V9sNpS2tjUV3d+y16FFuez8a1rXgT3E5YbOSJEEhi4CVkBvVLCp3LTVqWtLUpjzJPa9w LKu6LhX9N8HEMe9+bO58MyWkC2yUqvwfqLOvWpwZlr0ykpSWbgMsPufNoeMVfb4d/O74 6+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vF1D4ziTGh7E6yjRLQ/d3L84V5Gio+kElGO9NUrx4Pk=; b=g6EzS3VjDtBPU8cUiRA1t/5H1Hj4Q3XUlt7GIgtvb0gnFXqjZ/RE3GVHiZRi7qjFTb aGrGBQMMR2bnI4L/bLSO63SqrxXpzX8elw4QtJvLkvB8Gk4gLCKqXoHdtJAfmzRdnNM9 aos2xA8iTecNnjH1vHNEdRuHItBSdUcx8PSA52CH9LqAiViWuyj8zBY7/vPPctK+aI73 GwYifSHERT3NmjcwdD+Tlj2QzSLi3VInmmtNqkpe+TzM5zRI1Wcb3/RFTuu6zuI6ynuq 5sB3lK2LDyx1Y4z2k5xrsRy+QBxSP8dvtdUwnWqWc/V7/1RgtJyhhmzoQ58qSTSNEfyE s2aw== X-Gm-Message-State: APjAAAX2lhf1dE9NKjdcwEQkt2uV4NAM12BiUGmM2hUgrxlPdNNTFiVO jmsJ2mWvTvMBORuwMnxVbsFYsg== X-Google-Smtp-Source: APXvYqxwvj0mI6/5K10kcHJ0g11StV92HMITzIKYusIWHElo+iJZA0zvsATCGtQWrHg8FGv6brdh4g== X-Received: by 2002:a05:6000:1085:: with SMTP id y5mr7497131wrw.285.1565251313886; Thu, 08 Aug 2019 01:01:53 -0700 (PDT) Received: from localhost.localdomain (amontpellier-652-1-281-69.w109-210.abo.wanadoo.fr. [109.210.96.69]) by smtp.gmail.com with ESMTPSA id o7sm59383332wru.58.2019.08.08.01.01.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 08 Aug 2019 01:01:53 -0700 (PDT) From: Bartosz Golaszewski To: Guenter Roeck , Jean Delvare Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , kbuild test robot , Linus Walleij Subject: [PATCH][next] hwmon: pmbus: ucd9000: remove unneeded include Date: Thu, 8 Aug 2019 10:01:44 +0200 Message-Id: <20190808080144.6183-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Bartosz Golaszewski Build bot reports the following build issue after commit 9091373ab7ea ("gpio: remove less important #ifdef around declarations): In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: >> include/linux/gpio/driver.h:576:1: error: redefinition of 'gpiochip_add_pin_range' gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/hwmon/pmbus/ucd9000.c:18:0: include/linux/gpio.h:245:1: note: previous definition of 'gpiochip_add_pin_range' was here gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: >> include/linux/gpio/driver.h:583:1: error: redefinition of 'gpiochip_add_pingroup_range' gpiochip_add_pingroup_range(struct gpio_chip *chip, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/hwmon/pmbus/ucd9000.c:18:0: include/linux/gpio.h:254:1: note: previous definition of 'gpiochip_add_pingroup_range' was here gpiochip_add_pingroup_range(struct gpio_chip *chip, ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: >> include/linux/gpio/driver.h:591:1: error: redefinition of 'gpiochip_remove_pin_ranges' gpiochip_remove_pin_ranges(struct gpio_chip *chip) ^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/hwmon/pmbus/ucd9000.c:18:0: include/linux/gpio.h:263:1: note: previous definition of 'gpiochip_remove_pin_ranges' was here gpiochip_remove_pin_ranges(struct gpio_chip *chip) This is caused by conflicting defines from linux/gpio.h and linux/gpio/driver.h. Drivers should not include both the legacy and the new API headers. This driver doesn't even use linux/gpio.h so remove it. Reported-by: kbuild test robot Cc: Linus Walleij Signed-off-by: Bartosz Golaszewski --- drivers/hwmon/pmbus/ucd9000.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c index c846759bc1c0..a9229c6b0e84 100644 --- a/drivers/hwmon/pmbus/ucd9000.c +++ b/drivers/hwmon/pmbus/ucd9000.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include "pmbus.h"