diff mbox series

drivers/hwmon/adm1029.c: use simple i2c probe

Message ID 20200813161129.1507599-1-steve@sk2.org (mailing list archive)
State Accepted
Headers show
Series drivers/hwmon/adm1029.c: use simple i2c probe | expand

Commit Message

Stephen Kitt Aug. 13, 2020, 4:11 p.m. UTC
This driver doesn't use the id information provided by the old i2c
probe function, so it can trivially be converted to the simple
("probe_new") form.

Signed-off-by: Stephen Kitt <steve@sk2.org>
---
 drivers/hwmon/adm1029.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Corentin Labbe Aug. 14, 2020, 11:39 a.m. UTC | #1
On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
>  drivers/hwmon/adm1029.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
>  	return 1;
>  }
>  
> -static int adm1029_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
>  	.driver = {
>  		.name = "adm1029",
>  	},
> -	.probe		= adm1029_probe,
> +	.probe_new	= adm1029_probe,
>  	.id_table	= adm1029_id,
>  	.detect		= adm1029_detect,
>  	.address_list	= normal_i2c,
> -- 
> 2.25.4
> 
Hello

Acked-by: Corentin LABBE <clabbe.montjoie@gmail.com>

But please give me a few day to test it.
Corentin Labbe Aug. 17, 2020, 8:45 a.m. UTC | #2
On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
> 
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
>  drivers/hwmon/adm1029.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
>  	return 1;
>  }
>  
> -static int adm1029_probe(struct i2c_client *client,
> -			 const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
>  {
>  	struct device *dev = &client->dev;
>  	struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
>  	.driver = {
>  		.name = "adm1029",
>  	},
> -	.probe		= adm1029_probe,
> +	.probe_new	= adm1029_probe,
>  	.id_table	= adm1029_id,
>  	.detect		= adm1029_detect,
>  	.address_list	= normal_i2c,
> -- 
> 2.25.4
> 

Hello

Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks
diff mbox series

Patch

diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index f7752a5bef31..50b1df7b008c 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -352,8 +352,7 @@  static int adm1029_init_client(struct i2c_client *client)
 	return 1;
 }
 
-static int adm1029_probe(struct i2c_client *client,
-			 const struct i2c_device_id *id)
+static int adm1029_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
 	struct adm1029_data *data;
@@ -390,7 +389,7 @@  static struct i2c_driver adm1029_driver = {
 	.driver = {
 		.name = "adm1029",
 	},
-	.probe		= adm1029_probe,
+	.probe_new	= adm1029_probe,
 	.id_table	= adm1029_id,
 	.detect		= adm1029_detect,
 	.address_list	= normal_i2c,