diff mbox series

[1/1] dt-bindings: hwmon: pwm-fan: Support multiple fan tachometer inputs

Message ID 20200920180943.352526-2-pbarker@konsulko.com
State Accepted
Headers show
Series Document multiple fan tach support in pwm-fan driver | expand

Commit Message

Paul Barker Sept. 20, 2020, 6:09 p.m. UTC
Document and give an example of how to define multiple fan tachometer
inputs for the pwm-fan driver.

Signed-off-by: Paul Barker <pbarker@konsulko.com>
---
 .../devicetree/bindings/hwmon/pwm-fan.txt     | 28 +++++++++++++------
 1 file changed, 19 insertions(+), 9 deletions(-)

Comments

Rob Herring Sept. 29, 2020, 5:21 p.m. UTC | #1
On Sun, 20 Sep 2020 19:09:40 +0100, Paul Barker wrote:
> Document and give an example of how to define multiple fan tachometer
> inputs for the pwm-fan driver.
> 
> Signed-off-by: Paul Barker <pbarker@konsulko.com>
> ---
>  .../devicetree/bindings/hwmon/pwm-fan.txt     | 28 +++++++++++++------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Guenter Roeck Nov. 22, 2020, 3:29 p.m. UTC | #2
On Sun, Sep 20, 2020 at 07:09:40PM +0100, Paul Barker wrote:
> Document and give an example of how to define multiple fan tachometer
> inputs for the pwm-fan driver.
> 
> Signed-off-by: Paul Barker <pbarker@konsulko.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/pwm-fan.txt     | 28 +++++++++++++------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> index 41b76762953a..4509e688623a 100644
> --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> @@ -8,15 +8,16 @@ Required properties:
>  
>  Optional properties:
>  - fan-supply		: phandle to the regulator that provides power to the fan
> -- interrupts		: This contains a single interrupt specifier which
> -			  describes the tachometer output of the fan as an
> -			  interrupt source. The output signal must generate a
> -			  defined number of interrupts per fan revolution, which
> -			  require that it must be self resetting edge interrupts.
> -			  See interrupt-controller/interrupts.txt for the format.
> -- pulses-per-revolution : define the tachometer pulses per fan revolution as
> -			  an integer (default is 2 interrupts per revolution).
> -			  The value must be greater than zero.
> +- interrupts		: This contains an interrupt specifier for each fan
> +			  tachometer output connected to an interrupt source.
> +			  The output signal must generate a defined number of
> +			  interrupts per fan revolution, which require that
> +			  it must be self resetting edge interrupts. See
> +			  interrupt-controller/interrupts.txt for the format.
> +- pulses-per-revolution : define the number of pulses per fan revolution for
> +			  each tachometer input as an integer (default is 2
> +			  interrupts per revolution). The value must be
> +			  greater than zero.
>  
>  Example:
>  	fan0: pwm-fan {
> @@ -55,3 +56,12 @@ Example 2:
>  		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
>  		pulses-per-revolution = <2>;
>  	};
> +
> +Example 3:
> +	fan0: pwm-fan {
> +		compatible = "pwm-fan";
> +		pwms = <&pwm1 0 25000 0>;
> +		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
> +			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
> +		pulses-per-revolution = <2>, <1>;
> +	};
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
index 41b76762953a..4509e688623a 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
@@ -8,15 +8,16 @@  Required properties:
 
 Optional properties:
 - fan-supply		: phandle to the regulator that provides power to the fan
-- interrupts		: This contains a single interrupt specifier which
-			  describes the tachometer output of the fan as an
-			  interrupt source. The output signal must generate a
-			  defined number of interrupts per fan revolution, which
-			  require that it must be self resetting edge interrupts.
-			  See interrupt-controller/interrupts.txt for the format.
-- pulses-per-revolution : define the tachometer pulses per fan revolution as
-			  an integer (default is 2 interrupts per revolution).
-			  The value must be greater than zero.
+- interrupts		: This contains an interrupt specifier for each fan
+			  tachometer output connected to an interrupt source.
+			  The output signal must generate a defined number of
+			  interrupts per fan revolution, which require that
+			  it must be self resetting edge interrupts. See
+			  interrupt-controller/interrupts.txt for the format.
+- pulses-per-revolution : define the number of pulses per fan revolution for
+			  each tachometer input as an integer (default is 2
+			  interrupts per revolution). The value must be
+			  greater than zero.
 
 Example:
 	fan0: pwm-fan {
@@ -55,3 +56,12 @@  Example 2:
 		interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
 		pulses-per-revolution = <2>;
 	};
+
+Example 3:
+	fan0: pwm-fan {
+		compatible = "pwm-fan";
+		pwms = <&pwm1 0 25000 0>;
+		interrupts-extended = <&gpio1 1 IRQ_TYPE_EDGE_FALLING>,
+			<&gpio2 5 IRQ_TYPE_EDGE_FALLING>;
+		pulses-per-revolution = <2>, <1>;
+	};