| Message ID | 20210311073302.221954-1-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] hwmon: (adm9240) Drop log messages from detect function | expand |
On 11/03/21 8:33 pm, Guenter Roeck wrote: > Not detecting a chip in the detect function is normal and should not > generate any log messages, much less error messages. > > Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Tested-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > drivers/hwmon/adm9240.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c > index cc3e0184e720..3bbdd662c9e4 100644 > --- a/drivers/hwmon/adm9240.c > +++ b/drivers/hwmon/adm9240.c > @@ -730,26 +730,19 @@ static int adm9240_detect(struct i2c_client *new_client, > return -ENODEV; > > /* verify chip: reg address should match i2c address */ > - if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) > - != address) { > - dev_err(&adapter->dev, "detect fail: address match, 0x%02x\n", > - address); > + if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) != address) > return -ENODEV; > - } > > /* check known chip manufacturer */ > man_id = i2c_smbus_read_byte_data(new_client, ADM9240_REG_MAN_ID); > - if (man_id == 0x23) { > + if (man_id == 0x23) > name = "adm9240"; > - } else if (man_id == 0xda) { > + else if (man_id == 0xda) > name = "ds1780"; > - } else if (man_id == 0x01) { > + else if (man_id == 0x01) > name = "lm81"; > - } else { > - dev_err(&adapter->dev, "detect fail: unknown manuf, 0x%02x\n", > - man_id); > + else > return -ENODEV; > - } > > /* successful detect, print chip info */ > die_rev = i2c_smbus_read_byte_data(new_client, ADM9240_REG_DIE_REV);
diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c index cc3e0184e720..3bbdd662c9e4 100644 --- a/drivers/hwmon/adm9240.c +++ b/drivers/hwmon/adm9240.c @@ -730,26 +730,19 @@ static int adm9240_detect(struct i2c_client *new_client, return -ENODEV; /* verify chip: reg address should match i2c address */ - if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) - != address) { - dev_err(&adapter->dev, "detect fail: address match, 0x%02x\n", - address); + if (i2c_smbus_read_byte_data(new_client, ADM9240_REG_I2C_ADDR) != address) return -ENODEV; - } /* check known chip manufacturer */ man_id = i2c_smbus_read_byte_data(new_client, ADM9240_REG_MAN_ID); - if (man_id == 0x23) { + if (man_id == 0x23) name = "adm9240"; - } else if (man_id == 0xda) { + else if (man_id == 0xda) name = "ds1780"; - } else if (man_id == 0x01) { + else if (man_id == 0x01) name = "lm81"; - } else { - dev_err(&adapter->dev, "detect fail: unknown manuf, 0x%02x\n", - man_id); + else return -ENODEV; - } /* successful detect, print chip info */ die_rev = i2c_smbus_read_byte_data(new_client, ADM9240_REG_DIE_REV);
Not detecting a chip in the detect function is normal and should not generate any log messages, much less error messages. Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/hwmon/adm9240.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)