From patchwork Tue Apr 6 18:54:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12185763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4033C433B4 for ; Tue, 6 Apr 2021 18:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C7F96128A for ; Tue, 6 Apr 2021 18:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237099AbhDFSzO (ORCPT ); Tue, 6 Apr 2021 14:55:14 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43535 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239008AbhDFSzJ (ORCPT ); Tue, 6 Apr 2021 14:55:09 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lTqqo-0000lW-EP; Tue, 06 Apr 2021 18:54:58 +0000 From: Colin King To: Juerg Haefliger , Jean Delvare , Guenter Roeck , "Mark M . Hoffman" , linux-hwmon@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: (dme1737): Add missing null check on return from platform_get_resource Date: Tue, 6 Apr 2021 19:54:58 +0100 Message-Id: <20210406185458.433826-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org From: Colin Ian King The call to platform_get_resource can potentially return a NULL pointer on failure, so add this check and return -EINVAL if it fails. Addresses-Coverity: ("Dereference null return") Fixes: e95c237d78c0 ("hwmon: (dme1737) Add sch311x support") Signed-off-by: Colin Ian King --- drivers/hwmon/dme1737.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwmon/dme1737.c b/drivers/hwmon/dme1737.c index c1e4cfb40c3d..a2157872e126 100644 --- a/drivers/hwmon/dme1737.c +++ b/drivers/hwmon/dme1737.c @@ -2633,6 +2633,8 @@ static int dme1737_isa_probe(struct platform_device *pdev) int err; res = platform_get_resource(pdev, IORESOURCE_IO, 0); + if (!res) + return -EINVAL; if (!devm_request_region(dev, res->start, DME1737_EXTENT, "dme1737")) { dev_err(dev, "Failed to request region 0x%04x-0x%04x.\n", (unsigned short)res->start,