diff mbox series

hwmon: (w83627ehf) Make DEVICE_ATTR_RO static

Message ID 20210724154817.18796-1-W_Armin@gmx.de (mailing list archive)
State Accepted
Headers show
Series hwmon: (w83627ehf) Make DEVICE_ATTR_RO static | expand

Commit Message

Armin Wolf July 24, 2021, 3:48 p.m. UTC 
From: Armin Wolf <W_Armin@gmx.de>

Make DEVICE_ATTR_RO static to fix sparse warning:
warning: symbol 'dev_attr_cpu0_vid' was not declared. Should it be static?

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/hwmon/w83627ehf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.20.1

Comments

Guenter Roeck July 25, 2021, 3:21 a.m. UTC | #1 
On Sat, Jul 24, 2021 at 05:48:17PM +0200, W_Armin@gmx.de wrote:
> From: Armin Wolf <W_Armin@gmx.de>
> 
> Make DEVICE_ATTR_RO static to fix sparse warning:
> warning: symbol 'dev_attr_cpu0_vid' was not declared. Should it be static?
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/w83627ehf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --
> 2.20.1
> 
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index 3cea66c58c25..705a59663d42 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1081,7 +1081,7 @@ cpu0_vid_show(struct device *dev, struct device_attribute *attr, char *buf)
>  	struct w83627ehf_data *data = dev_get_drvdata(dev);
>  	return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
>  }
> -DEVICE_ATTR_RO(cpu0_vid);
> +static DEVICE_ATTR_RO(cpu0_vid);
> 
> 
>  /* Case open detection */
diff mbox series

Patch

diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index 3cea66c58c25..705a59663d42 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1081,7 +1081,7 @@  cpu0_vid_show(struct device *dev, struct device_attribute *attr, char *buf)
 	struct w83627ehf_data *data = dev_get_drvdata(dev);
 	return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
 }
-DEVICE_ATTR_RO(cpu0_vid);
+static DEVICE_ATTR_RO(cpu0_vid);


 /* Case open detection */