| Message ID | 20220215151022.7498-2-eajames@linux.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (occ) Add various poll response data in sysfs | expand |
On Tue, 15 Feb 2022 at 15:11, Eddie James <eajames@linux.ibm.com> wrote: > > BMC control applications need to check the Idle Power Saver status > byte returned by the OCC poll response, so export it in sysfs with > the other OCC-specific data. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > drivers/hwmon/occ/common.h | 1 + > drivers/hwmon/occ/sysfs.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h > index 5020117be740..a88c66d36e38 100644 > --- a/drivers/hwmon/occ/common.h > +++ b/drivers/hwmon/occ/common.h > @@ -119,6 +119,7 @@ struct occ { > u8 prev_stat; > u8 prev_ext_stat; > u8 prev_occs_present; > + u8 prev_ips_status; > }; > > int occ_setup(struct occ *occ, const char *name); > diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c > index 03b16abef67f..6dc69c9aa4c2 100644 > --- a/drivers/hwmon/occ/sysfs.c > +++ b/drivers/hwmon/occ/sysfs.c > @@ -63,6 +63,9 @@ static ssize_t occ_sysfs_show(struct device *dev, > else > val = 1; > break; > + case 8: > + val = header->ips_status; > + break; > default: > return -EINVAL; > } > @@ -88,6 +91,7 @@ static SENSOR_DEVICE_ATTR(occ_mem_throttle, 0444, occ_sysfs_show, NULL, 4); > static SENSOR_DEVICE_ATTR(occ_quick_pwr_drop, 0444, occ_sysfs_show, NULL, 5); > static SENSOR_DEVICE_ATTR(occ_state, 0444, occ_sysfs_show, NULL, 6); > static SENSOR_DEVICE_ATTR(occs_present, 0444, occ_sysfs_show, NULL, 7); > +static SENSOR_DEVICE_ATTR(occ_ips_status, 0444, occ_sysfs_show, NULL, 8); > static DEVICE_ATTR_RO(occ_error); > > static struct attribute *occ_attributes[] = { > @@ -99,6 +103,7 @@ static struct attribute *occ_attributes[] = { > &sensor_dev_attr_occ_quick_pwr_drop.dev_attr.attr, > &sensor_dev_attr_occ_state.dev_attr.attr, > &sensor_dev_attr_occs_present.dev_attr.attr, > + &sensor_dev_attr_occ_ips_status.dev_attr.attr, > &dev_attr_occ_error.attr, > NULL > }; > @@ -162,6 +167,11 @@ void occ_sysfs_poll_done(struct occ *occ) > sysfs_notify(&occ->bus_dev->kobj, NULL, name); > } > > + if (header->ips_status != occ->prev_ips_status) { > + name = sensor_dev_attr_occ_ips_status.dev_attr.attr.name; > + sysfs_notify(&occ->bus_dev->kobj, NULL, name); > + } > + > if (occ->error && occ->error != occ->prev_error) { > name = dev_attr_occ_error.attr.name; > sysfs_notify(&occ->bus_dev->kobj, NULL, name); > @@ -174,6 +184,7 @@ void occ_sysfs_poll_done(struct occ *occ) > occ->prev_stat = header->status; > occ->prev_ext_stat = header->ext_status; > occ->prev_occs_present = header->occs_present; > + occ->prev_ips_status = header->ips_status; > } > > int occ_setup_sysfs(struct occ *occ) > -- > 2.27.0 >
On Tue, Feb 15, 2022 at 09:10:19AM -0600, Eddie James wrote: > BMC control applications need to check the Idle Power Saver status > byte returned by the OCC poll response, so export it in sysfs with > the other OCC-specific data. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > Reviewed-by: Joel Stanley <joel@jms.id.au> Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/occ/common.h | 1 + > drivers/hwmon/occ/sysfs.c | 11 +++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h > index 5020117be740..a88c66d36e38 100644 > --- a/drivers/hwmon/occ/common.h > +++ b/drivers/hwmon/occ/common.h > @@ -119,6 +119,7 @@ struct occ { > u8 prev_stat; > u8 prev_ext_stat; > u8 prev_occs_present; > + u8 prev_ips_status; > }; > > int occ_setup(struct occ *occ, const char *name); > diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c > index 03b16abef67f..6dc69c9aa4c2 100644 > --- a/drivers/hwmon/occ/sysfs.c > +++ b/drivers/hwmon/occ/sysfs.c > @@ -63,6 +63,9 @@ static ssize_t occ_sysfs_show(struct device *dev, > else > val = 1; > break; > + case 8: > + val = header->ips_status; > + break; > default: > return -EINVAL; > } > @@ -88,6 +91,7 @@ static SENSOR_DEVICE_ATTR(occ_mem_throttle, 0444, occ_sysfs_show, NULL, 4); > static SENSOR_DEVICE_ATTR(occ_quick_pwr_drop, 0444, occ_sysfs_show, NULL, 5); > static SENSOR_DEVICE_ATTR(occ_state, 0444, occ_sysfs_show, NULL, 6); > static SENSOR_DEVICE_ATTR(occs_present, 0444, occ_sysfs_show, NULL, 7); > +static SENSOR_DEVICE_ATTR(occ_ips_status, 0444, occ_sysfs_show, NULL, 8); > static DEVICE_ATTR_RO(occ_error); > > static struct attribute *occ_attributes[] = { > @@ -99,6 +103,7 @@ static struct attribute *occ_attributes[] = { > &sensor_dev_attr_occ_quick_pwr_drop.dev_attr.attr, > &sensor_dev_attr_occ_state.dev_attr.attr, > &sensor_dev_attr_occs_present.dev_attr.attr, > + &sensor_dev_attr_occ_ips_status.dev_attr.attr, > &dev_attr_occ_error.attr, > NULL > }; > @@ -162,6 +167,11 @@ void occ_sysfs_poll_done(struct occ *occ) > sysfs_notify(&occ->bus_dev->kobj, NULL, name); > } > > + if (header->ips_status != occ->prev_ips_status) { > + name = sensor_dev_attr_occ_ips_status.dev_attr.attr.name; > + sysfs_notify(&occ->bus_dev->kobj, NULL, name); > + } > + > if (occ->error && occ->error != occ->prev_error) { > name = dev_attr_occ_error.attr.name; > sysfs_notify(&occ->bus_dev->kobj, NULL, name); > @@ -174,6 +184,7 @@ void occ_sysfs_poll_done(struct occ *occ) > occ->prev_stat = header->status; > occ->prev_ext_stat = header->ext_status; > occ->prev_occs_present = header->occs_present; > + occ->prev_ips_status = header->ips_status; > } > > int occ_setup_sysfs(struct occ *occ)
diff --git a/drivers/hwmon/occ/common.h b/drivers/hwmon/occ/common.h index 5020117be740..a88c66d36e38 100644 --- a/drivers/hwmon/occ/common.h +++ b/drivers/hwmon/occ/common.h @@ -119,6 +119,7 @@ struct occ { u8 prev_stat; u8 prev_ext_stat; u8 prev_occs_present; + u8 prev_ips_status; }; int occ_setup(struct occ *occ, const char *name); diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c index 03b16abef67f..6dc69c9aa4c2 100644 --- a/drivers/hwmon/occ/sysfs.c +++ b/drivers/hwmon/occ/sysfs.c @@ -63,6 +63,9 @@ static ssize_t occ_sysfs_show(struct device *dev, else val = 1; break; + case 8: + val = header->ips_status; + break; default: return -EINVAL; } @@ -88,6 +91,7 @@ static SENSOR_DEVICE_ATTR(occ_mem_throttle, 0444, occ_sysfs_show, NULL, 4); static SENSOR_DEVICE_ATTR(occ_quick_pwr_drop, 0444, occ_sysfs_show, NULL, 5); static SENSOR_DEVICE_ATTR(occ_state, 0444, occ_sysfs_show, NULL, 6); static SENSOR_DEVICE_ATTR(occs_present, 0444, occ_sysfs_show, NULL, 7); +static SENSOR_DEVICE_ATTR(occ_ips_status, 0444, occ_sysfs_show, NULL, 8); static DEVICE_ATTR_RO(occ_error); static struct attribute *occ_attributes[] = { @@ -99,6 +103,7 @@ static struct attribute *occ_attributes[] = { &sensor_dev_attr_occ_quick_pwr_drop.dev_attr.attr, &sensor_dev_attr_occ_state.dev_attr.attr, &sensor_dev_attr_occs_present.dev_attr.attr, + &sensor_dev_attr_occ_ips_status.dev_attr.attr, &dev_attr_occ_error.attr, NULL }; @@ -162,6 +167,11 @@ void occ_sysfs_poll_done(struct occ *occ) sysfs_notify(&occ->bus_dev->kobj, NULL, name); } + if (header->ips_status != occ->prev_ips_status) { + name = sensor_dev_attr_occ_ips_status.dev_attr.attr.name; + sysfs_notify(&occ->bus_dev->kobj, NULL, name); + } + if (occ->error && occ->error != occ->prev_error) { name = dev_attr_occ_error.attr.name; sysfs_notify(&occ->bus_dev->kobj, NULL, name); @@ -174,6 +184,7 @@ void occ_sysfs_poll_done(struct occ *occ) occ->prev_stat = header->status; occ->prev_ext_stat = header->ext_status; occ->prev_occs_present = header->occs_present; + occ->prev_ips_status = header->ips_status; } int occ_setup_sysfs(struct occ *occ)
BMC control applications need to check the Idle Power Saver status byte returned by the OCC poll response, so export it in sysfs with the other OCC-specific data. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/hwmon/occ/common.h | 1 + drivers/hwmon/occ/sysfs.c | 11 +++++++++++ 2 files changed, 12 insertions(+)