@@ -423,13 +423,17 @@ static int sch5627_probe(struct platform_device *pdev)
struct sch5627_data *data;
struct device *hwmon_dev;
int err, build_code, build_id, hwmon_rev, val;
+ struct resource *res;
data = devm_kzalloc(&pdev->dev, sizeof(struct sch5627_data),
GFP_KERNEL);
if (!data)
return -ENOMEM;
- data->addr = platform_get_resource(pdev, IORESOURCE_IO, 0)->start;
+ res = platform_get_resource(pdev, IORESOURCE_IO, 0);
+ if (!res)
+ return -EINVAL;
+ data->addr = res->start;
mutex_init(&data->update_lock);
platform_set_drvdata(pdev, data);
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Fixes: a98d506c08ff ("hwmon: New driver for SMSC SCH5627") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/hwmon/sch5627.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)