| Message ID | 20220425100019.562781-1-camel.guo@axis.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (tmp401) Fix incorrect return value of tmp401_init_client | expand |
On Mon, Apr 25, 2022 at 12:00:19PM +0200, Camel Guo wrote: > When ti,n-factor, ti,beta-compentation are not defined in devicetree, > of_property_read_u32|s32 returns -EINVAL. In this case, > tmp401_init_client should return 0 instead of simply pass ret to its > caller. > > Fixes: c825ca044988 ("hwmon: (tmp401) Add support of three advanced features") > Signed-off-by: Camel Guo <camel.guo@axis.com> Good catch. Thanks, applied. Guenter > --- > drivers/hwmon/tmp401.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c > index 8f49da997367..a58a2f31a07e 100644 > --- a/drivers/hwmon/tmp401.c > +++ b/drivers/hwmon/tmp401.c > @@ -604,7 +604,7 @@ static int tmp401_init_client(struct tmp401_data *data) > return ret; > } > > - return ret; > + return 0; > } > > static int tmp401_detect(struct i2c_client *client,
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index 8f49da997367..a58a2f31a07e 100644 --- a/drivers/hwmon/tmp401.c +++ b/drivers/hwmon/tmp401.c @@ -604,7 +604,7 @@ static int tmp401_init_client(struct tmp401_data *data) return ret; } - return ret; + return 0; } static int tmp401_detect(struct i2c_client *client,
When ti,n-factor, ti,beta-compentation are not defined in devicetree, of_property_read_u32|s32 returns -EINVAL. In this case, tmp401_init_client should return 0 instead of simply pass ret to its caller. Fixes: c825ca044988 ("hwmon: (tmp401) Add support of three advanced features") Signed-off-by: Camel Guo <camel.guo@axis.com> --- drivers/hwmon/tmp401.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)