From patchwork Fri Jun 3 15:21:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: D Scott Phillips X-Patchwork-Id: 12869150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664C9C433EF for ; Fri, 3 Jun 2022 15:21:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbiFCPV0 (ORCPT ); Fri, 3 Jun 2022 11:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiFCPVZ (ORCPT ); Fri, 3 Jun 2022 11:21:25 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2127.outbound.protection.outlook.com [40.107.223.127]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F5D506C3; Fri, 3 Jun 2022 08:21:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4+cCNlC8kOYK8F/xHBQK9J5zVNRGjmZ8ShnWwjX6csRXTF89TNyFm3Pkx4qMBVsAhbMHK1kbMAqt55tnWiUXp82SNx9Ta+gqpuGvb97B5rcAXm7ELxP1Xj3LOj4b00BgnqhRSr8ilAMYvs9caRjTTTV/HIj4JQQQD1WBCntj4lXRTqn0gATY91jm9siAgD0BX/tonZvPRYZOlCXaVU5SSM+W3ZPt5XpVMMqIR1vL57RlbSf5qdEtsOjXOeYEkaBtM+cXbd2WuwUgwshUZ0wImqhSqoI1ED4s8OgqNDmr/sjdWQH/jgJOQ4pEhhH6YdbfFstKskHLBQ1to0DFZqciw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvgcHcbTSl/MmZx3FmCNReIJMktR9MoYW0K+Y4RCw7I=; b=ZMK+/Pii+kCCIYs4mL6EPnxUUSFK6IABJVVby9r+rEIqWEBvgLdBTNlvMExrR8jqppygM+nGTqjHmwVtnUpEynwDFPB4Gea0QqYeLbvwVT07E1rDPHKsil2wx7qnawfxcqwfeGb5KvSsEygLXZKR6XMX29AxnMdp9mqokQeLuoNy8FVQ5bkkLwv/sapCaUZnmZYBUmMHCX7g4n+w+Ho2y0UB6jDv9JmPIgjR9Z5Xq3v+xYt0kI4HXznk9gQOPvUYOGkYd07aJoqbIOPiI69WNu4mYRK21b+iIv3ru3hrrvBFkkFfmDAQO2rzuM3/uXp0Xg02UM/jzW5ORXJj+AjyLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvgcHcbTSl/MmZx3FmCNReIJMktR9MoYW0K+Y4RCw7I=; b=qkHmZw5sJrERCrpG9zm0wtzEmQ+rh8vc6RInanIB3ce06JenqQxFC7LuoXbiDrvSmMosJ/kFuCiGB5OAvjBVy7r4imTvJu/lXdE0Lmj9FO7Qley28nnyDgTqgVwR+XCBJJV6OFmGBEVbO0YE6pOjUWYE6kswTfbTZHdcBH5Ureg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from MWHPR0101MB2893.prod.exchangelabs.com (2603:10b6:301:33::25) by CY4PR01MB2566.prod.exchangelabs.com (2603:10b6:903:6e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.18; Fri, 3 Jun 2022 15:21:22 +0000 Received: from MWHPR0101MB2893.prod.exchangelabs.com ([fe80::b8d8:b445:2b14:bed3]) by MWHPR0101MB2893.prod.exchangelabs.com ([fe80::b8d8:b445:2b14:bed3%3]) with mapi id 15.20.5293.019; Fri, 3 Jun 2022 15:21:22 +0000 From: D Scott Phillips To: linux-hwmon@vger.kernel.org Cc: Jean Delvare , Guenter Roeck , linux-kernel@vger.kernel.org, patches@amperecomputing.com, Darren Hart , Ilkka Koskinen Subject: [PATCH] hwmon: (xgene) restrict power measurements to admin by default Date: Fri, 3 Jun 2022 08:21:16 -0700 Message-Id: <20220603152116.2269912-1-scott@os.amperecomputing.com> X-Mailer: git-send-email 2.35.1 X-ClientProxiedBy: CH2PR18CA0047.namprd18.prod.outlook.com (2603:10b6:610:55::27) To MWHPR0101MB2893.prod.exchangelabs.com (2603:10b6:301:33::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8de71d1-28f8-46a1-7373-08da4574b6a7 X-MS-TrafficTypeDiagnostic: CY4PR01MB2566:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WZvEN63MVwzWRVEfjMkLIUHQDeHQOBk9gdf8UbqvE2OGr5wHF+QXC8fI9MfX0/B8WB2QZZDamOHigeSYhcxaKAQnQSONVujbN3gfysxSyj8DiwEItzAcQImDo+sdkn28EqSt10g2jfWWxBc2NqCx2grphJ/T3zR8fxjO+3XYKxlFmjSLBtny6m1aesWczRZIsL7qIpnmLjPx8j5yspsEFMgUMx3O/+diKPLjXoZyLakyXI6gPVSOD+hwjTfqZPUQXuYGyDdN/hiRCYCQvcU7fGeDmHzVshCFrmWSoOnzuOMF4f2N+dinEwRrvJomEbc6qEgNgPGOPJzvqGb8vmoxg4A/tnXrzVqsTg0unn39w8xNOL8gZJ/HDH7mGawERTJ8dmYHnJjAh8b1SQ4dxpKUZjclS9pFazSxU/eHA1MxzrN0HMYZ1ZMMDyqVQnRQ/HM9eqHbqFGDR/xDjlQX+G6QJFO7+1gLIXdT4m3m8uG2XyC2nKeHNkJlC5lhxxZWJSGCKwtNKgAf6aTkVx0wq0TbHlwrBTOWryjrpQOYjvh9uh/15Z6N6x+IYY9CLvpwbppQ6HqK32hN5VeH4SOHijBYCv42Wg9jBHDsOUduTQy5+OLG7tAaPa3SYlXu+lvsF6u/khL+Rop0Z1IHLDMYPxOJPY4UJL14CB1r3HDt9qcX2BZe0WaNzaW/FFD20K47FdXZawFa06xJ2HdqgwW0IZXCtg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR0101MB2893.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(26005)(86362001)(66476007)(66946007)(6916009)(54906003)(66556008)(186003)(6506007)(8936002)(52116002)(5660300002)(6666004)(38350700002)(6486002)(38100700002)(8676002)(107886003)(6512007)(2616005)(1076003)(4326008)(2906002)(316002)(508600001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RqdWT2qs3uy5ZQza9WoYi/Z+h7KyCu3nLNrIqBAopBZyXBT+kCP/pmcoJJjoFlEc2Q2gr9/SZCKOtl8zK29hW4QG5144hStO2Mw9kor2zhk20YE6LpXky/EjKHnJ5GBkyDBYdITOukG/eA+QANTz9waqwtEGb4Hc25M12RvjvfYB3jUJ0HRVHXsFf5zZMDvH+8Kxn/Rpgi3Wz7rrTpWoL4vTanttg6zC3ZnrxynlA/2o2jnkuV2Ak1Tp9wlM0FIvK1Mi94K7tOgqDjVG3//RxJTIik9S1oMgdlrATujWKHyw5PAMnBzqHEuhzD1H7FVtgereCSQxjXUP8rWenap9od7jUPTVGGQ1DtTAuITie7w0p6oyYhaZVP0XB21CTD5n0igKLhU3HHBbhxpwHWQ9yfJJtfi8elmkyLyR1N4jcifYwgRkcaN1WOU5NPu/KUtRseFNsIe0NuKyy67cSR5emILBcKT1OYivi42tbrqiRvEhE7TpjntwTvRSawl+CkPVkXbwckwo1nwdhwNW2nTn91N0YvPcU/4WvUtOaCCBZCtadGFkH2sTOt/xoKCNYdB0KgHEPD3YUU8vrQg+wJGsQCdI1Jy6z4lR1BeIEOkhiY9CueIq1UVKmnzgLd6DdRsBlhyCLghACnAY1TZYbGrdHexN2wwqrVtZ8D+fAD+O6mRLRN0Xq6+1EDZYIfSpGzy0XHWKFgLfvZ0cFAxI2bLCeLabUUNz814dlTbpkeVwmU7khq7QipqehclafDR+w04lakzsBZDMrZZCmEZmaUjd2zLdSosOjNHG6UnBfQttVjJEDMzkZhP6cZMm4FWYQEO6q90Dre64mrDgvi0ZKyWMfdLSOAvllp1tGIhwIt5tFvydzBy5+4bgjtGKASl3WH1ekbho9aF7bWjKKmhmbtlunIQ4+j9QhMvbwmml/VPyGb38NZLhu2Itprwqy17KgVNAzmkslIeqNXARMuIkJtWy+sxJYsoJSydzQssnSJ7PvughAEgFaNdZVUV0z2lakvmu7hH6NN0kQQjeMZlaVODB/Is04LJ+5VbZplQ4jzEvf0UTmxC70pjF1/WjB7dx75vnF04tLbTrXeRGj8r+zsyb7N9kilCJ4pIUybdUjoRIW7bK+xoDnXtXBwVxZtoWqP6//1pYEGfrF1y90QQpzKqaWuyNZKaZBrk6ZnDWaunmD02RlIToRWL3bLV4gLaxHxrRm/dvxkisYqQzAcgX1x8hR1xY2URsx/51fb/rZfO9iTYC6OKtfU9ALTK9gxh+yEktHqWZg/lgrsGcLASoHlp34JHnFQ5r17KYdKOCTFKCci3BjPXQC2Y6ooXVyNVfGz/pbJ3Br6vt4yZJA9OfcyAa29XXoN4BzWfAWG8bsFLGJcADrJYB/oPstHrqwh9BFqi+XEXGWLlMRfO5tAZyMWlxa6501KITWe1eScaDYK+XNvNXYjZXSAOL5zkg77k5SlS8qy4PU4PaEe/rp9N852gvNk+Q50H0pAG8PEuh2fhKck2rwFu0u6N/27AxuyMrkYR1eibFIdxSK6jupMZ2SRexNYjAs7+VU6Hh2eyycLtH0waEMUfusT25b2KBfjLWQ9Qcjtf4vHcnT8ztTqFYSY5n3wiLOVo1Trf3HXZaFdL6bfzk20knuSnoktOnKgLod0Uhhje4yUotWGEF6N+WOuV9ZJ7WNRH7ZUrcmjGQ+MUxQDdAUar+qbKCzGGdkQSaxnsKxSNdsLsFMEUYWp/grTLAVLa6HjwBjSrkhlnISzKcJZwPI2L2IKG8eTwsZOXS5jJj X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8de71d1-28f8-46a1-7373-08da4574b6a7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2893.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2022 15:21:22.1327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ianfho7KpNUrSJ0Uhfj3dKkYxAte1IceHo+4u/wghuCpwHPpBcYyNjPI4dY0dhi3VZQ/uQJR3GpMAwh/6usjTDZayZc0HpGck5tLlQH5j35mFUl2T5Vd5zXIlopaSrJm X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR01MB2566 Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Access to power information can be used to infer the instructions being run and possibly even data being processed on a cpu[1]. Restrict access to power information to administrator users by default. (Cf. a similar powercap change[2].) [1]: Lipp, Moritz, et al. "PLATYPUS: software-based power side-channel attacks on x86." 2021 IEEE Symposium on Security and Privacy (SP). IEEE, 2021. [2]: commit 949dd0104c49 ("powercap: restrict energy meter to root access") Fixes: ed42cfa881e1 ("hwmon: Add xgene hwmon driver") Signed-off-by: D Scott Phillips Cc: stable@vger.kernel.org --- drivers/hwmon/xgene-hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c index 5cde837bfd09..6ad1daf2d354 100644 --- a/drivers/hwmon/xgene-hwmon.c +++ b/drivers/hwmon/xgene-hwmon.c @@ -397,9 +397,9 @@ static DEVICE_ATTR_RO(temp1_label); static DEVICE_ATTR_RO(temp1_input); static DEVICE_ATTR_RO(temp1_critical_alarm); static DEVICE_ATTR_RO(power1_label); -static DEVICE_ATTR_RO(power1_input); +static DEVICE_ATTR_ADMIN_RO(power1_input); static DEVICE_ATTR_RO(power2_label); -static DEVICE_ATTR_RO(power2_input); +static DEVICE_ATTR_ADMIN_RO(power2_input); static struct attribute *xgene_hwmon_attrs[] = { &dev_attr_temp1_label.attr,