| Message ID | 20220615125105.3966317-1-windhl@126.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drivers: w1: Add missing of_node_put() in w1.c | expand |
On Wed, 15 Jun 2022 20:51:05 +0800, Liang He wrote: > In __w1_attach_slave_device, we really need not to use of_node_put > in normal path as the reference is escaped by sl. However, we need > of_node_put in the fail path before put_device. > > Applied, thanks! [1/1] drivers: w1: Add missing of_node_put() in w1.c https://git.kernel.org/krzk/linux-w1/c/51cbbcd6469b2a32e222ec220039af20a16f2769 Best regards,
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index f2ae2e563dc5..44a0587105a8 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -702,6 +702,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl) dev_err(&sl->dev, "Device registration [%s] failed. err=%d\n", dev_name(&sl->dev), err); + of_node_put(sl->dev.of_node); put_device(&sl->dev); return err; }
In __w1_attach_slave_device, we really need not to use of_node_put in normal path as the reference is escaped by sl. However, we need of_node_put in the fail path before put_device. Signed-off-by: Liang He <windhl@126.com> --- drivers/w1/w1.c | 1 + 1 file changed, 1 insertion(+)