Message ID | 20220908082358.186268-4-Ibrahim.Tilki@analog.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | hwmon: Add max31760 fan speed controller | expand |
On 9/8/22 01:23, Ibrahim Tilki wrote: > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> This time you dropped the maintainers from Cc:. Why ? Guenter > --- > .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > new file mode 100644 > index 000000000..003ec1317 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,max31760.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX31760 Fan-Speed Controller > + > +maintainers: > + - Ibrahim Tilki <Ibrahim.Tilki@analog.com> > + > +description: | > + Analog Devices MAX31760 Fan-Speed Controller > + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf > + > +properties: > + compatible: > + enum: > + - adi,max31760 > + > + reg: > + description: | > + I2C address of slave device. > + items: > + minimum: 0x50 > + maximum: 0x57 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c0 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + max31760@50 { > + reg = <0x50>; > + compatible = "adi,max31760"; > + }; > + };
> On 9/8/22 01:23, Ibrahim Tilki wrote: > > Adding bindings for Analog Devices MAX31760 Fan-Speed Controller > > > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> > > This time you dropped the maintainers from Cc:. Why ? > > Guenter > I thought I need to send the patch to devicetree list <devicetree@vger.kernel.org> instead of sending directly to maintainers as per Rob's reply. Should I add them to Cc as well and resend again? Ibrahim > > --- > > .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > new file mode 100644 > > index 000000000..003ec1317 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/adi,m > > +ax31760.yaml*__;Iw!!A3Ni8CS0y2Y!4jxXOqgSL2JDA_zhVxa1gDg-X3GvtxnISuyIJ > > +0fz_0Blfkx3tzqwICgIVHzIxrv7-7nDoCZqZgYJ0OtFP8A$ > > +$schema: > > +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y > > +aml*__;Iw!!A3Ni8CS0y2Y!4jxXOqgSL2JDA_zhVxa1gDg-X3GvtxnISuyIJ0fz_0Blfk > > +x3tzqwICgIVHzIxrv7-7nDoCZqZgYJ5GeDd5g$ > > + > > +title: Analog Devices MAX31760 Fan-Speed Controller > > + > > +maintainers: > > + - Ibrahim Tilki <Ibrahim.Tilki@analog.com> > > + > > +description: | > > + Analog Devices MAX31760 Fan-Speed Controller > > + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf > > + > > +properties: > > + compatible: > > + enum: > > + - adi,max31760 > > + > > + reg: > > + description: | > > + I2C address of slave device. > > + items: > > + minimum: 0x50 > > + maximum: 0x57 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + max31760@50 { > > + reg = <0x50>; > > + compatible = "adi,max31760"; > > + }; > > + };
On 9/8/22 08:46, Tilki, Ibrahim wrote: > >> On 9/8/22 01:23, Ibrahim Tilki wrote: >>> Adding bindings for Analog Devices MAX31760 Fan-Speed Controller >>> >>> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> >> >> This time you dropped the maintainers from Cc:. Why ? >> >> Guenter >> > > I thought I need to send the patch to devicetree list <devicetree@vger.kernel.org> > instead of sending directly to maintainers as per Rob's reply. I don't think Rob said "instead" in his e-mail. He asked you to send the patches to the recipients listed by the get_maintainers script. > Should I add them to Cc as well and resend again? > You'll wee if/when he replies. Note that you got a 0-day report, so you'll have to send another version of your series anyway with the reported problem fixed. Thanks, Guenter > Ibrahim > > >>> --- >>> .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/hwmon/adi,max31760.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml >>> b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml >>> new file mode 100644 >>> index 000000000..003ec1317 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml >>> @@ -0,0 +1,44 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>> +--- >>> +$id: >>> +https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/adi,m >>> +ax31760.yaml*__;Iw!!A3Ni8CS0y2Y!4jxXOqgSL2JDA_zhVxa1gDg-X3GvtxnISuyIJ >>> +0fz_0Blfkx3tzqwICgIVHzIxrv7-7nDoCZqZgYJ0OtFP8A$ >>> +$schema: >>> +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y >>> +aml*__;Iw!!A3Ni8CS0y2Y!4jxXOqgSL2JDA_zhVxa1gDg-X3GvtxnISuyIJ0fz_0Blfk >>> +x3tzqwICgIVHzIxrv7-7nDoCZqZgYJ5GeDd5g$ >>> + >>> +title: Analog Devices MAX31760 Fan-Speed Controller >>> + >>> +maintainers: >>> + - Ibrahim Tilki <Ibrahim.Tilki@analog.com> >>> + >>> +description: | >>> + Analog Devices MAX31760 Fan-Speed Controller >>> + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - adi,max31760 >>> + >>> + reg: >>> + description: | >>> + I2C address of slave device. >>> + items: >>> + minimum: 0x50 >>> + maximum: 0x57 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + i2c0 { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + max31760@50 { >>> + reg = <0x50>; >>> + compatible = "adi,max31760"; >>> + }; >>> + };
diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml new file mode 100644 index 000000000..003ec1317 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/adi,max31760.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/adi,max31760.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices MAX31760 Fan-Speed Controller + +maintainers: + - Ibrahim Tilki <Ibrahim.Tilki@analog.com> + +description: | + Analog Devices MAX31760 Fan-Speed Controller + https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf + +properties: + compatible: + enum: + - adi,max31760 + + reg: + description: | + I2C address of slave device. + items: + minimum: 0x50 + maximum: 0x57 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c0 { + #address-cells = <1>; + #size-cells = <0>; + + max31760@50 { + reg = <0x50>; + compatible = "adi,max31760"; + }; + };
Adding bindings for Analog Devices MAX31760 Fan-Speed Controller Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com> --- .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml