| Message ID | 20220913135401.1973721-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [-next] platform/x86: asus-wmi: change kbd_rgb_mode_groups to static | expand |
Hi, On 9/13/22 15:54, Yang Yingliang wrote: > kbd_rgb_mode_groups is only used in asus-wmi.c now, change it > to static. > > Fixes: e305a71cea37 ("platform/x86: asus-wmi: Implement TUF laptop keyboard LED modes") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Thank you for your patch. This has already been fixed in my review-hans branchm, so I am going to drop this patch. Regards, Hans > --- > drivers/platform/x86/asus-wmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c > index d95170b7dba0..ae46af731de9 100644 > --- a/drivers/platform/x86/asus-wmi.c > +++ b/drivers/platform/x86/asus-wmi.c > @@ -835,7 +835,7 @@ static const struct attribute_group kbd_rgb_state_group = { > .attrs = kbd_rgb_state_attrs, > }; > > -const struct attribute_group *kbd_rgb_mode_groups[] = { > +static const struct attribute_group *kbd_rgb_mode_groups[] = { > NULL, > NULL, > NULL,
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index d95170b7dba0..ae46af731de9 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -835,7 +835,7 @@ static const struct attribute_group kbd_rgb_state_group = { .attrs = kbd_rgb_state_attrs, }; -const struct attribute_group *kbd_rgb_mode_groups[] = { +static const struct attribute_group *kbd_rgb_mode_groups[] = { NULL, NULL, NULL,
kbd_rgb_mode_groups is only used in asus-wmi.c now, change it to static. Fixes: e305a71cea37 ("platform/x86: asus-wmi: Implement TUF laptop keyboard LED modes") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/platform/x86/asus-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)