| Message ID | 20230103013145.9570-2-hal.feng@starfivetech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Temperature sensor support for StarFive JH7110 RISC-V SoC | expand |
On Tue, Jan 03, 2023 at 09:31:42AM +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Add bindings for the temperature sensor on the StarFive JH7100 and > JH7110 SoCs. > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> The previous version of this bindings document (v3, https://patchwork.kernel.org/project/linux-hwmon/patch/20210726171802.1052716-2-kernel@esmil.dk/ had been reviewed by Rob Herring. Even though this version is named differently (starfive,jh71x0-temp.yaml instead of starfive,jh7100-temp.yaml), the old version should be referenced, and there should be a change log. Guenter > --- > .../bindings/hwmon/starfive,jh71x0-temp.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > new file mode 100644 > index 000000000000..2600881e2cdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/starfive,jh71x0-temp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71x0 Temperature Sensor > + > +maintainers: > + - Emil Renner Berthing <kernel@esmil.dk> > + > +description: | > + StarFive Technology Co. JH71x0 embedded temperature sensor > + > +properties: > + compatible: > + enum: > + - starfive,jh7100-temp > + - starfive,jh7110-temp > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 2 > + maxItems: 2 > + > + clock-names: > + items: > + - const: "sense" > + - const: "bus" > + > + '#thermal-sensor-cells': > + const: 0 > + > + interrupts: > + maxItems: 1 > + > + resets: > + minItems: 2 > + maxItems: 2 > + > + reset-names: > + items: > + - const: "sense" > + - const: "bus" > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - resets > + - reset-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/starfive-jh7100.h> > + #include <dt-bindings/reset/starfive-jh7100.h> > + > + tmon@124a0000 { > + compatible = "starfive,jh7100-temp"; > + reg = <0x124a0000 0x10000>; > + clocks = <&clkgen JH7100_CLK_TEMP_SENSE>, > + <&clkgen JH7100_CLK_TEMP_APB>; > + clock-names = "sense", "bus"; > + #thermal-sensor-cells = <0>; > + interrupts = <122>; > + resets = <&rstgen JH7100_RSTN_TEMP_SENSE>, > + <&rstgen JH7100_RSTN_TEMP_APB>; > + reset-names = "sense", "bus"; > + };
On Tue, 3 Jan 2023 14:14:05 -0800, Guenter Roeck wrote: > On Tue, Jan 03, 2023 at 09:31:42AM +0800, Hal Feng wrote: >> From: Emil Renner Berthing <kernel@esmil.dk> >> >> Add bindings for the temperature sensor on the StarFive JH7100 and >> JH7110 SoCs. >> >> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> >> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > The previous version of this bindings document (v3, > https://patchwork.kernel.org/project/linux-hwmon/patch/20210726171802.1052716-2-kernel@esmil.dk/ > had been reviewed by Rob Herring. Even though this version is named differently > (starfive,jh71x0-temp.yaml instead of starfive,jh7100-temp.yaml), the old version > should be referenced, and there should be a change log. Will add the Reviewed-by tag of Rob and add a change log. Thank you again. Best regards, Hal
diff --git a/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml new file mode 100644 index 000000000000..2600881e2cdc --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/starfive,jh71x0-temp.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/starfive,jh71x0-temp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: StarFive JH71x0 Temperature Sensor + +maintainers: + - Emil Renner Berthing <kernel@esmil.dk> + +description: | + StarFive Technology Co. JH71x0 embedded temperature sensor + +properties: + compatible: + enum: + - starfive,jh7100-temp + - starfive,jh7110-temp + + reg: + maxItems: 1 + + clocks: + minItems: 2 + maxItems: 2 + + clock-names: + items: + - const: "sense" + - const: "bus" + + '#thermal-sensor-cells': + const: 0 + + interrupts: + maxItems: 1 + + resets: + minItems: 2 + maxItems: 2 + + reset-names: + items: + - const: "sense" + - const: "bus" + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - resets + - reset-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/starfive-jh7100.h> + #include <dt-bindings/reset/starfive-jh7100.h> + + tmon@124a0000 { + compatible = "starfive,jh7100-temp"; + reg = <0x124a0000 0x10000>; + clocks = <&clkgen JH7100_CLK_TEMP_SENSE>, + <&clkgen JH7100_CLK_TEMP_APB>; + clock-names = "sense", "bus"; + #thermal-sensor-cells = <0>; + interrupts = <122>; + resets = <&rstgen JH7100_RSTN_TEMP_SENSE>, + <&rstgen JH7100_RSTN_TEMP_APB>; + reset-names = "sense", "bus"; + };