diff mbox series

[v4,1/5] dt-bindings: hwmon: adi,ltc2945: Add binding

Message ID 20230126-b4-ltc2945_shunt_resistor-v4-1-bb913470d8da@criticallink.com (mailing list archive)
State Accepted
Headers show
Series hwmon: ltc2945: Add binding and shunt resistor support | expand

Commit Message

Jonathan Cormier Jan. 26, 2023, 10:32 p.m. UTC 
Create initial binding for the LTC2945 I2C power monitor.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
---
 .../devicetree/bindings/hwmon/adi,ltc2945.yaml     | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)

Comments

Guenter Roeck Jan. 29, 2023, 8:16 p.m. UTC | #1 
On Thu, Jan 26, 2023 at 05:32:23PM -0500, Jonathan Cormier wrote:
> Create initial binding for the LTC2945 I2C power monitor.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>

Series applied, after merging patch 4/5 and 5/5 of the series
to avoid spurious 32-bit build failures, and after fixing a
continuation line alignment.

In the future, please run checkpatch --strict on your patches,
and please provide change logs.

Thanks,
Guenter
Jonathan Cormier Jan. 30, 2023, 3:19 p.m. UTC | #2 
On Sun, Jan 29, 2023 at 3:16 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Thu, Jan 26, 2023 at 05:32:23PM -0500, Jonathan Cormier wrote:
> > Create initial binding for the LTC2945 I2C power monitor.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
>
> Series applied,
Great
> after merging patch 4/5 and 5/5 of the series
> to avoid spurious 32-bit build failures,
Huh, I split these per request, curious why they'd cause build
failures when separated...
> and after fixing a continuation line alignment.
>
> In the future, please run checkpatch --strict on your patches,
Will do. I didn't know about this option.
> and please provide change logs.
This I did do in every cover letter.
>
> Thanks,
> Guenter
Jonathan Cormier Jan. 30, 2023, 3:25 p.m. UTC | #3 
On Mon, Jan 30, 2023 at 10:19 AM Jon Cormier <jcormier@criticallink.com> wrote:
>
> On Sun, Jan 29, 2023 at 3:16 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Thu, Jan 26, 2023 at 05:32:23PM -0500, Jonathan Cormier wrote:
> > > Create initial binding for the LTC2945 I2C power monitor.
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
> >
> > Series applied,
> Great
> > after merging patch 4/5 and 5/5 of the series
> > to avoid spurious 32-bit build failures,
> Huh, I split these per request, curious why they'd cause build
> failures when separated...
Nevermind, I see your other response.
> > and after fixing a continuation line alignment.
> >
> > In the future, please run checkpatch --strict on your patches,
> Will do. I didn't know about this option.
> > and please provide change logs.
> This I did do in every cover letter.
> >
> > Thanks,
> > Guenter
>
> --
> Jonathan Cormier
> Software Engineer
>
> Voice:  315.425.4045 x222
>
>
>
> http://www.CriticalLink.com
> 6712 Brooklawn Parkway, Syracuse, NY 13211
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
new file mode 100644
index 000000000000..5cb66e97e816
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
@@ -0,0 +1,49 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices LTC2945 wide range i2c power monitor
+
+maintainers:
+  - Guenter Roeck <linux@roeck-us.net>
+
+description: |
+  Analog Devices LTC2945 wide range i2c power monitor over I2C.
+
+  https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf
+
+properties:
+  compatible:
+    enum:
+      - adi,ltc2945
+
+  reg:
+    maxItems: 1
+
+  shunt-resistor-micro-ohms:
+    description:
+      Shunt resistor value in micro-Ohms
+    default: 1000
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        power-monitor@6e {
+            compatible = "adi,ltc2945";
+            reg = <0x6e>;
+            /* 10 milli-Ohm shunt resistor */
+            shunt-resistor-micro-ohms = <10000>;
+        };
+    };
+...