| Message ID | 20230222005228.158661-2-tony.obrien@alliedtelesis.co.nz (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | hwmon: (adt7475) Fixes for acoustics and hysteresis | expand |
On Wed, Feb 22, 2023 at 01:52:27PM +1300, Tony O'Brien wrote: > Throughout the ADT7475 driver, attributes relating to the temperature > sensors are displayed in the order Remote 1, Local, Remote 2. Make > temp_st_show() conform to this expectation so that values set by > temp_st_store() can be displayed using the correct attribute. > > Fixes: 8f05bcc33e74 ("hwmon: (adt7475) temperature smoothing") > Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> Applied. Thanks, Guenter > --- > Changes in v2: > - None > drivers/hwmon/adt7475.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c > index 51b3d16c3223..77222c35a38e 100644 > --- a/drivers/hwmon/adt7475.c > +++ b/drivers/hwmon/adt7475.c > @@ -556,11 +556,11 @@ static ssize_t temp_st_show(struct device *dev, struct device_attribute *attr, > val = data->enh_acoustics[0] & 0xf; > break; > case 1: > - val = (data->enh_acoustics[1] >> 4) & 0xf; > + val = data->enh_acoustics[1] & 0xf; > break; > case 2: > default: > - val = data->enh_acoustics[1] & 0xf; > + val = (data->enh_acoustics[1] >> 4) & 0xf; > break; > } >
diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c index 51b3d16c3223..77222c35a38e 100644 --- a/drivers/hwmon/adt7475.c +++ b/drivers/hwmon/adt7475.c @@ -556,11 +556,11 @@ static ssize_t temp_st_show(struct device *dev, struct device_attribute *attr, val = data->enh_acoustics[0] & 0xf; break; case 1: - val = (data->enh_acoustics[1] >> 4) & 0xf; + val = data->enh_acoustics[1] & 0xf; break; case 2: default: - val = data->enh_acoustics[1] & 0xf; + val = (data->enh_acoustics[1] >> 4) & 0xf; break; }
Throughout the ADT7475 driver, attributes relating to the temperature sensors are displayed in the order Remote 1, Local, Remote 2. Make temp_st_show() conform to this expectation so that values set by temp_st_store() can be displayed using the correct attribute. Fixes: 8f05bcc33e74 ("hwmon: (adt7475) temperature smoothing") Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> --- Changes in v2: - None drivers/hwmon/adt7475.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)