| Message ID | 20230320154019.1943770-3-lakshmiy@us.ibm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hwmon: (pmbus/acbel-crps) Add Acbel CRPS power supply driver | expand |
On 20/03/2023 16:40, Lakshmi Yadlapati wrote: > Add Acbel CRPS Series power supply to trivial devices. > > Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 6f482a254a1d..ae2cf4411b39 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -30,6 +30,8 @@ properties: > items: > - enum: > # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin > + - acbel,crps > + # Acbel CRPS Series power supply Wrong placements of comments. This is AD, not Acbel. > - ad,ad7414 > # ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems > - ad,adm9240 Best regards, Krzysztof
On 3/20/23, 11:29 AM, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org <mailto:krzysztof.kozlowski@linaro.org>> wrote: On 20/03/2023 16:40, Lakshmi Yadlapati wrote: > Add Acbel CRPS Series power supply to trivial devices. > > Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com <mailto:lakshmiy@us.ibm.com>> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 6f482a254a1d..ae2cf4411b39 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -30,6 +30,8 @@ properties: > items: > - enum: > # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin > + - acbel,crps > + # Acbel CRPS Series power supply Wrong placements of comments. This is AD, not Acbel. I will fix it. Thx > - ad,ad7414 > # ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems > - ad,adm9240 Best regards, Krzysztof
On Mon, Mar 20, 2023 at 10:40:16AM -0500, Lakshmi Yadlapati wrote: > Add Acbel CRPS Series power supply to trivial devices. > > Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 6f482a254a1d..ae2cf4411b39 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -30,6 +30,8 @@ properties: > items: > - enum: > # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin > + - acbel,crps > + # Acbel CRPS Series power supply This is way too generic. There is not just one Acbel CRPS power supply, there is a whole lot of them. It is very unlikely that they can all be described with a single devicetree "compatible" property. Guenter > - ad,ad7414 > # ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems > - ad,adm9240 > -- > 2.37.2 >
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 6f482a254a1d..ae2cf4411b39 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -30,6 +30,8 @@ properties: items: - enum: # SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert and Over Temperature Pin + - acbel,crps + # Acbel CRPS Series power supply - ad,ad7414 # ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems - ad,adm9240
Add Acbel CRPS Series power supply to trivial devices. Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)