diff mbox series

[v2,2/2] hwmon: (coretemp) Delete an obsolete comment

Message ID 20230330103346.6044-2-rui.zhang@intel.com (mailing list archive)
State Accepted
Headers show
Series [v2,1/2] hwmon: (coretemp) Delete tjmax debug message | expand

Commit Message

Zhang, Rui March 30, 2023, 10:33 a.m. UTC
The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
has been changed for several times.

Now, the raw value from MSR is used without refinement. Thus remove the
obsolete comment.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/hwmon/coretemp.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Guenter Roeck April 7, 2023, 4:01 p.m. UTC | #1
On Thu, Mar 30, 2023 at 06:33:46PM +0800, Zhang Rui wrote:
> The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
> has been changed for several times.
> 
> Now, the raw value from MSR is used without refinement. Thus remove the
> obsolete comment.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/coretemp.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index fe3d4d0dcbed..eba94f68585a 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
>  			dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
>  	} else {
>  		val = (eax >> 16) & 0xff;
> -		/*
> -		 * If the TjMax is not plausible, an assumption
> -		 * will be used
> -		 */
>  		if (val)
>  			return val * 1000;
>  	}
diff mbox series

Patch

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index fe3d4d0dcbed..eba94f68585a 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -282,10 +282,6 @@  static int get_tjmax(struct temp_data *tdata, struct device *dev)
 			dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
 	} else {
 		val = (eax >> 16) & 0xff;
-		/*
-		 * If the TjMax is not plausible, an assumption
-		 * will be used
-		 */
 		if (val)
 			return val * 1000;
 	}