| Message ID | 20230406203103.3011503-13-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show
Return-Path: <linux-hwmon-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
by smtp.lore.kernel.org (Postfix) with ESMTP id 67586C77B6F
for <linux-hwmon@archiver.kernel.org>; Thu, 6 Apr 2023 20:32:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S239649AbjDFUcW (ORCPT <rfc822;linux-hwmon@archiver.kernel.org>);
Thu, 6 Apr 2023 16:32:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36314 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S239505AbjDFUb7 (ORCPT
<rfc822;linux-hwmon@vger.kernel.org>); Thu, 6 Apr 2023 16:31:59 -0400
Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com
[IPv6:2a00:1450:4864:20::630])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50495B74C
for <linux-hwmon@vger.kernel.org>;
Thu, 6 Apr 2023 13:31:43 -0700 (PDT)
Received: by mail-ej1-x630.google.com with SMTP id l15so4218124ejq.10
for <linux-hwmon@vger.kernel.org>;
Thu, 06 Apr 2023 13:31:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1680813102;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=Q738x7YwOS0X3XmE9hZfN9Ce15/MYjfZeq6pSQ5ilpI=;
b=zy7BsgELujF2TPKCiJuSaYGU32HQ47Wnx8gile3JZ+/AgQXY8WdeOW4obbFD1dAIRj
uvJw+TfNSxls3c5pR8LDLmgLowzfPQsPuBV/CW056h9mYKnjpTUtCfltSV71rmQHN/z2
/eyqN6fAe25ulQsOOcjeqVFUCuoARqhTmXUuHld3T29X0n09hsvJMgBzTEIMKTFW2km9
/IXj7PDEAjhd4WAMeo8Fxh+szfqGiQOS0CXJTWgk4wpQ1uexo3u3NO41aKEWdOdVtnBL
WqCMfNpldHDYZIWn27eqxOPcANqyCMYrQ5IKv4Si6qKXHV4X+Qh5rGVvEYsb/EPDUFMh
Hq1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1680813102;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Q738x7YwOS0X3XmE9hZfN9Ce15/MYjfZeq6pSQ5ilpI=;
b=KUqHAYj+kQeQDmGXhMEVXvktIREtW0Q0ezU5UKkhGZMUXXAjbgdzgenlaUfGWHQn2a
PWBnNM110gkJxssEe74KnmMlBL9QqkuQDkZJ/xUTX+v/vJULku8DyWBudZw30hV1ZcAR
17iAd+UUdA3cMGWzKB2qvNVOSiswchRmEkhvVRUuQZ8ffoCd3CuWjVLXMYJQqaohz4s6
wKzAX1SxNT958CN0UVz+/ZYuhDLR29O3krv3n9xMJS57df8k/FuYxxTHPId0z85wcnqL
KLa/+9IaVu7PIpDku13lbvL5GPjTe55vjLpB2Giq+uj1LEWkoSwjpPgUsDbzfyyRxS8A
qLBA==
X-Gm-Message-State: AAQBX9eJf+D4aNd+4MMj+13/+Q9+SnNocAkxFXadT8MKaLzcRbNwh+wm
GTBNpjbvCjWP8aLWbsFe0BCOEA==
X-Google-Smtp-Source:
AKy350YG+aKLeJk+41CCwPZ32gqUjvwfzA9HY7Ve4lEg7WnoUkQNi0XJVnjTSA7FZiCwflxqK0bw0w==
X-Received: by 2002:a17:907:6ea6:b0:8f0:143d:ee34 with SMTP id
sh38-20020a1709076ea600b008f0143dee34mr7334618ejc.1.1680813102050;
Thu, 06 Apr 2023 13:31:42 -0700 (PDT)
Received: from krzk-bin.. ([2a02:810d:15c0:828:49e6:bb8c:a05b:c4ed])
by smtp.gmail.com with ESMTPSA id
s4-20020a1709067b8400b0092bea699124sm1210330ejo.106.2023.04.06.13.31.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 06 Apr 2023 13:31:41 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>, Oded Gabbay <ogabbay@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Aleksa Savic <savicaleksa83@gmail.com>, Jack Doan <me@jackdoan.com>,
=?utf-8?q?Nuno_S=C3=A1?= <nuno.sa@analog.com>,
Marius Zachmann <mail@mariuszachmann.de>,
Wilken Gottwalt <wilken.gottwalt@posteo.net>,
=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
Jean-Marie Verdun <verdun@hpe.com>, Nick Hawkins <nick.hawkins@hpe.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Clemens Ladisch <clemens@ladisch.de>, Rudolf Marek <r.marek@assembler.cz>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>,
Jonas Malaco <jonas@protocubo.io>,
Aleksandr Mezin <mezin.alexander@gmail.com>,
Derek John Clark <derekjohn.clark@gmail.com>, =?utf-8?q?Joaqu=C3=ADn_Ignaci?=
=?utf-8?q?o_Aramend=C3=ADa?= <samsagax@gmail.com>,
Iwona Winiarska <iwona.winiarska@intel.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
Hans de Goede <hdegoede@redhat.com>, Michael Walle <michael@walle.cc>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>, UNGLinuxDriver@microchip.com,
Agathe Porte <agathe.porte@nokia.com>,
Eric Tremblay <etremblay@distech-controls.com>,
Robert Marko <robert.marko@sartura.hr>, Luka Perkov <luka.perkov@sartura.hr>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
patches@opensource.cirrus.com, openbmc@lists.ozlabs.org,
linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 12/68] hwmon: corsair: constify pointers to hwmon_channel_info
Date: Thu, 6 Apr 2023 22:30:07 +0200
Message-Id: <20230406203103.3011503-13-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230406203103.3011503-1-krzysztof.kozlowski@linaro.org>
References: <20230406203103.3011503-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-hwmon.vger.kernel.org>
X-Mailing-List: linux-hwmon@vger.kernel.org
|
| Series |
hwmon: constify pointers to hwmon_channel_info
|
expand
|
On Thu, 6 Apr 2023 22:30:07 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c > index 2210aa62e3d0..dc24c566d08b 100644 > --- a/drivers/hwmon/corsair-psu.c > +++ b/drivers/hwmon/corsair-psu.c > @@ -571,7 +571,7 @@ static const struct hwmon_ops corsairpsu_hwmon_ops = { > .read_string = corsairpsu_hwmon_ops_read_string, > }; > > -static const struct hwmon_channel_info *corsairpsu_info[] = { > +static const struct hwmon_channel_info * const corsairpsu_info[] = { > HWMON_CHANNEL_INFO(chip, > HWMON_C_REGISTER_TZ), > HWMON_CHANNEL_INFO(temp, Wait a minute. Can you at least match it to the coding style of the driver? A lot of work went into it to keep it consistent. greetings, Will
diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c index fa6aa4fc8b52..463ab4296ede 100644 --- a/drivers/hwmon/corsair-cpro.c +++ b/drivers/hwmon/corsair-cpro.c @@ -385,7 +385,7 @@ static const struct hwmon_ops ccp_hwmon_ops = { .write = ccp_write, }; -static const struct hwmon_channel_info *ccp_info[] = { +static const struct hwmon_channel_info * const ccp_info[] = { HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ), HWMON_CHANNEL_INFO(temp, diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c index 2210aa62e3d0..dc24c566d08b 100644 --- a/drivers/hwmon/corsair-psu.c +++ b/drivers/hwmon/corsair-psu.c @@ -571,7 +571,7 @@ static const struct hwmon_ops corsairpsu_hwmon_ops = { .read_string = corsairpsu_hwmon_ops_read_string, }; -static const struct hwmon_channel_info *corsairpsu_info[] = { +static const struct hwmon_channel_info * const corsairpsu_info[] = { HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ), HWMON_CHANNEL_INFO(temp,
Statically allocated array of pointed to hwmon_channel_info can be made const for safety. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/hwmon/corsair-cpro.c | 2 +- drivers/hwmon/corsair-psu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)