| Message ID | 20230413123039.22473-1-daniel.matyas@analog.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Unclear what to do with compatibility | expand |
On 13/04/2023 14:30, Daniel Matyas wrote: > MAX31827 is a low-power temperature switch with I2C interface. You sent a new patch. With a weird subject. I don't understand exactly what is this. > > The device is a ±1°C accuracy from -40°C to +125°C > (12 bits) local temperature switch and sensor with I2C/SM- > Bus interface. The combination of small 6-bump wafer-lev- > el package (WLP) and high accuracy makes this temper- > ature sensor/switch ideal for a wide range of applications. > > Signed-off-by: Daniel Matyas <daniel.matyas@analog.com> > --- > .../bindings/hwmon/adi,max31827.yaml | 51 +++++++++++++++++++ > MAINTAINERS | 7 +++ > 2 files changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > new file mode 100644 > index 000000000000..37177eb9c039 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/adi,max31827.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch > + > +maintainers: > + - Daniel Matyas <daniel.matyas@analog.com> > + > +description: | > + Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch with > + I2C Interface > + https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31827-MAX31829.pdf > + > +properties: > + compatible: > + enum: > + - adi,max31827 > + - adi,max31828 > + - adi,max31829 > + > > I am really sorry, but I do not understand what I should do. > > Should I add oneOf or items to the compatibility property? The devices should be marked as compatible with each other, so you can drop useless match table entries. https://elixir.bootlin.com/linux/v6.3-rc6/source/Documentation/devicetree/bindings/sound/nvidia,tegra210-ope.yaml#L31 and fix this in the driver. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml new file mode 100644 index 000000000000..37177eb9c039 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/adi,max31827.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch + +maintainers: + - Daniel Matyas <daniel.matyas@analog.com> + +description: | + Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch with + I2C Interface + https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31827-MAX31829.pdf + +properties: + compatible: + enum: + - adi,max31827 + - adi,max31828 + - adi,max31829 + I am really sorry, but I do not understand what I should do. Should I add oneOf or items to the compatibility property? + reg: + maxItems: 1 + + vref-supply: + description: + Must have values in the interval (1.6V; 3.6V) in order for the device to + function correctly. + +required: + - compatible + - reg + - vref-supply + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@42 { + compatible = "adi,max31827"; + reg = <0x42>; + vref-supply = <®_vdd>; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 0e64787aace8..8af1296ff1a0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12535,6 +12535,13 @@ F: Documentation/userspace-api/media/drivers/max2175.rst F: drivers/media/i2c/max2175* F: include/uapi/linux/max2175.h +MAX31827 TEMPERATURE SWITCH DRIVER +M: Daniel Matyas <daniel.matyas@analog.com> +L: linux-hwmon@vger.kernel.org +S: Supported +W: http://ez.analog.com/community/linux-device-drivers +F: Documentation/devicetree/bindings/hwmon/adi,max31827.yaml + MAX6650 HARDWARE MONITOR AND FAN CONTROLLER DRIVER L: linux-hwmon@vger.kernel.org S: Orphan
MAX31827 is a low-power temperature switch with I2C interface. The device is a ±1°C accuracy from -40°C to +125°C (12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications. Signed-off-by: Daniel Matyas <daniel.matyas@analog.com> --- .../bindings/hwmon/adi,max31827.yaml | 51 +++++++++++++++++++ MAINTAINERS | 7 +++ 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31827.yaml