| Message ID | 20230420171939.212040-1-tomas.pecka@cesnet.cz (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E | expand |
On Thu, Apr 20, 2023 at 07:19:39PM +0200, Tomáš Pecka wrote: > The bit flags in pmbus_driver_info functionality for YM-2151E chip were > joined with a comma operator instead of a bitwise OR. This means that > the last constant PMBUS_HAVE_IIN was not OR-ed with the other > PM_BUS_HAVE_* constants for this page but it initialized the next element > of the func array (which was not accessed from anywhere because of the > number of pages). > > However, there is no need for setting PMBUS_HAVE_IIN in the 5Vsb page > because this command does not seem to be paged. Obviously, the device > only has one IIN sensor, so it doesn't make sense to query it again from > the second page. > > Fixes: 1734b4135a62 ("hwmon: Add driver for fsp-3y PSUs and PDUs") > Co-developed-by: Jan Kundrát <jan.kundrat@cesnet.cz> > Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> FWIW, adding both Co-developed-by: and Signed-off-by: tags doesn't make sense since Signed-off-by: implies Co-developed-by:. I'll drop the first tag. > Signed-off-by: Tomáš Pecka <tomas.pecka@cesnet.cz> Applied. Thanks, Guenter > --- > drivers/hwmon/pmbus/fsp-3y.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c > index aec294cc72d1..c7469d2cdedc 100644 > --- a/drivers/hwmon/pmbus/fsp-3y.c > +++ b/drivers/hwmon/pmbus/fsp-3y.c > @@ -180,7 +180,6 @@ static struct pmbus_driver_info fsp3y_info[] = { > PMBUS_HAVE_FAN12, > .func[YM2151_PAGE_5VSB_LOG] = > PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT, > - PMBUS_HAVE_IIN, > .read_word_data = fsp3y_read_word_data, > .read_byte_data = fsp3y_read_byte_data, > },
diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c index aec294cc72d1..c7469d2cdedc 100644 --- a/drivers/hwmon/pmbus/fsp-3y.c +++ b/drivers/hwmon/pmbus/fsp-3y.c @@ -180,7 +180,6 @@ static struct pmbus_driver_info fsp3y_info[] = { PMBUS_HAVE_FAN12, .func[YM2151_PAGE_5VSB_LOG] = PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT, - PMBUS_HAVE_IIN, .read_word_data = fsp3y_read_word_data, .read_byte_data = fsp3y_read_byte_data, },
The bit flags in pmbus_driver_info functionality for YM-2151E chip were joined with a comma operator instead of a bitwise OR. This means that the last constant PMBUS_HAVE_IIN was not OR-ed with the other PM_BUS_HAVE_* constants for this page but it initialized the next element of the func array (which was not accessed from anywhere because of the number of pages). However, there is no need for setting PMBUS_HAVE_IIN in the 5Vsb page because this command does not seem to be paged. Obviously, the device only has one IIN sensor, so it doesn't make sense to query it again from the second page. Fixes: 1734b4135a62 ("hwmon: Add driver for fsp-3y PSUs and PDUs") Co-developed-by: Jan Kundrát <jan.kundrat@cesnet.cz> Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz> Signed-off-by: Tomáš Pecka <tomas.pecka@cesnet.cz> --- drivers/hwmon/pmbus/fsp-3y.c | 1 - 1 file changed, 1 deletion(-)