diff mbox series

[v2,1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001

Message ID 20230714064336.28371-1-andre.werner@systec-electronic.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001 | expand

Commit Message

werneazc July 14, 2023, 6:43 a.m. UTC
This is the initial description.

Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring (Arm) July 14, 2023, 9:09 p.m. UTC | #1
On Fri, 14 Jul 2023 08:43:35 +0200, Andre Werner wrote:
> This is the initial description.
> 
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski July 16, 2023, 4:32 p.m. UTC | #2
On 14/07/2023 08:43, Andre Werner wrote:
> This is the initial description.
> 
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Didn't you get this comment already? If so, why you decided to ignore it?

>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index ba2bfb547909..5a5de3f6cd37 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -320,6 +320,8 @@ properties:
>              # Rohm DH2228FV
>            - rohm,dh2228fv
>              # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
> +          - renesas,hs3001
> +            # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors

Wrong placement of comment.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index ba2bfb547909..5a5de3f6cd37 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -320,6 +320,8 @@  properties:
             # Rohm DH2228FV
           - rohm,dh2228fv
             # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
+          - renesas,hs3001
+            # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors
           - samsung,24ad0xd1
             # Samsung Exynos SoC SATA PHY I2C device
           - samsung,exynos-sataphy-i2c