| Message ID | 20230718112810.21322-1-andre.werner@systec-electronic.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3,1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001 | expand |
On 18/07/2023 13:28, Andre Werner wrote: > This is the initial description. > > Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 Best regards, Krzysztof
On Tue, Jul 18, 2023 at 01:28:09PM +0200, Andre Werner wrote: > This is the initial description. > > Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> checkpatch: WARNING: From:/Signed-off-by: email address mismatch: 'From: Andre Werner <werneazc@gmail.com>' != 'Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>' Sorry, you'll have to resend this. The e-mail addresses need to match. Note that, when doing so, I would suggest to add a sensible description. "This is the initial description." is not a useful description. "Add binding for Renesas HS3001 Temperature and Relative Humidity Sensor" would be more sensible. Also, regarding the subject: bindings don't describe the driver, they describe the chip. Thanks, Guenter > --- > v1: Using separate dt-binding hs300x.yaml > v2: Reviewer recommends documentation of driver dt-binding in > trivial-devices.yaml because the driver has no special properties > to describe. > v3: Simplify description of sensors compatible > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index ba2bfb547909..96eb59e56eb7 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -315,6 +315,8 @@ properties: > - plx,pex8648 > # Pulsedlight LIDAR range-finding sensor > - pulsedlight,lidar-lite-v2 > + # Renesas HS3001 Temperature and Relative Humidity Sensors > + - renesas,hs3001 > # Renesas ISL29501 time-of-flight sensor > - renesas,isl29501 > # Rohm DH2228FV
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index ba2bfb547909..96eb59e56eb7 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -315,6 +315,8 @@ properties: - plx,pex8648 # Pulsedlight LIDAR range-finding sensor - pulsedlight,lidar-lite-v2 + # Renesas HS3001 Temperature and Relative Humidity Sensors + - renesas,hs3001 # Renesas ISL29501 time-of-flight sensor - renesas,isl29501 # Rohm DH2228FV
This is the initial description. Signed-off-by: Andre Werner <andre.werner@systec-electronic.com> --- v1: Using separate dt-binding hs300x.yaml v2: Reviewer recommends documentation of driver dt-binding in trivial-devices.yaml because the driver has no special properties to describe. v3: Simplify description of sensors compatible --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)