| Message ID | 20230925082334.8310-1-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] drivers: hwmon: max31827: handle vref regulator | expand |
On Mon, Sep 25, 2023 at 11:23:33AM +0300, Antoniu Miclaus wrote: > Add missing implementation for the max31827 supply regulator. > This is a hardware required property that is not handled. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v3: > - revert also the dev_err_probe output to use "vref" instead of "vdd". > drivers/hwmon/max31827.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c > index 602f4e4f81ff..2a61fb9a408a 100644 > --- a/drivers/hwmon/max31827.c > +++ b/drivers/hwmon/max31827.c > @@ -427,6 +427,11 @@ static int max31827_probe(struct i2c_client *client) > return dev_err_probe(dev, PTR_ERR(st->regmap), > "Failed to allocate regmap.\n"); > > + err = devm_regulator_get_enable(dev, "vref"); > + if (err) > + return dev_err_probe(dev, err, > + "failed to enable vref regulator\n"); Please drop the "vref". "failed to enable regulator" is sufficient. Guenter > + > err = max31827_init_client(st); > if (err) > return err; > -- > 2.42.0 >
diff --git a/drivers/hwmon/max31827.c b/drivers/hwmon/max31827.c index 602f4e4f81ff..2a61fb9a408a 100644 --- a/drivers/hwmon/max31827.c +++ b/drivers/hwmon/max31827.c @@ -427,6 +427,11 @@ static int max31827_probe(struct i2c_client *client) return dev_err_probe(dev, PTR_ERR(st->regmap), "Failed to allocate regmap.\n"); + err = devm_regulator_get_enable(dev, "vref"); + if (err) + return dev_err_probe(dev, err, + "failed to enable vref regulator\n"); + err = max31827_init_client(st); if (err) return err;
Add missing implementation for the max31827 supply regulator. This is a hardware required property that is not handled. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v3: - revert also the dev_err_probe output to use "vref" instead of "vdd". drivers/hwmon/max31827.c | 5 +++++ 1 file changed, 5 insertions(+)